[PATCH] S390: Increase function alignment to 16 bytes.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] S390: Increase function alignment to 16 bytes.

Stefan Liebler-2
Hi,

this patch sets the default function alignment to 16 bytes in order to
get rid of some unwanted performance effects.

Please see also GCC commit "S/390: Set default function
alignment to 16."

Bye,
Stefan

ChangeLog:

        * sysdeps/s390/s390-64/sysdep.h(ENTRY): Use alignment of 16byte.
        * sysdeps/s390/s390-32/sysdep.h: Likewise.

20190301_function_alignment.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] S390: Increase function alignment to 16 bytes.

Florian Weimer-5
* Stefan Liebler:

> commit 3ca7542058593c6870ca10d0eed801ccc4326a4c
> Author: Stefan Liebler <[hidden email]>
> Date:   Wed Feb 20 09:02:56 2019 +0100
>
>     S390: Increase function alignment to 16 bytes.
>    
>     Set the default function alignment to 16 bytes in order to
>     get rid of some unwanted performance effects.
>    
>     Please see also GCC commit "S/390: Set default function
>     alignment to 16."
>    
>     ChangeLog:
>    
>             * sysdeps/s390/s390-64/sysdep.h(ENTRY): Use alignment of
>             16byte.

“16 bytes”?  Maybe also reference Subversion revision (rXXX) in the
commit message if it's already committed to GCC.

The actual change looks fine to me (though I can't comment on the
performance implications 8-).

Thanks,
Florian
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] S390: Increase function alignment to 16 bytes.

Stefan Liebler-2
On 3/1/19 4:47 PM, Florian Weimer wrote:

> * Stefan Liebler:
>
>> commit 3ca7542058593c6870ca10d0eed801ccc4326a4c
>> Author: Stefan Liebler <[hidden email]>
>> Date:   Wed Feb 20 09:02:56 2019 +0100
>>
>>      S390: Increase function alignment to 16 bytes.
>>      
>>      Set the default function alignment to 16 bytes in order to
>>      get rid of some unwanted performance effects.
>>      
>>      Please see also GCC commit "S/390: Set default function
>>      alignment to 16."
>>      
>>      ChangeLog:
>>      
>>              * sysdeps/s390/s390-64/sysdep.h(ENTRY): Use alignment of
>>              16byte.
>
> “16 bytes”?  Maybe also reference Subversion revision (rXXX) in the
> commit message if it's already committed to GCC.
>
> The actual change looks fine to me (though I can't comment on the
> performance implications 8-).
>
> Thanks,
> Florian
>

Committed with the additional information of the gcc commit:
Subversion revision 262817

Thanks,
Stefan