[PATCH] Remove do_set_mallopt_check prototype

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Remove do_set_mallopt_check prototype

H.J. Lu-30
Remove do_set_mallopt_check prototype since it is unused.

        * malloc/arena.c (do_set_mallopt_check): Removed.
---
 malloc/arena.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/malloc/arena.c b/malloc/arena.c
index 10a77b0232..8340b20b56 100644
--- a/malloc/arena.c
+++ b/malloc/arena.c
@@ -207,7 +207,6 @@ __malloc_fork_unlock_child (void)
 }
 
 #if HAVE_TUNABLES
-static inline int do_set_mallopt_check (int32_t value);
 void
 TUNABLE_CALLBACK (set_mallopt_check) (tunable_val_t *valp)
 {
--
2.20.1

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Remove do_set_mallopt_check prototype

Carlos O'Donell-5
On 4/23/19 3:39 PM, H.J. Lu wrote:
> Remove do_set_mallopt_check prototype since it is unused.
>
> * malloc/arena.c (do_set_mallopt_check): Removed.
> ---

LGTM.

Reviewed-by: Carlos O'Donell <[hidden email]>

>   malloc/arena.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/malloc/arena.c b/malloc/arena.c
> index 10a77b0232..8340b20b56 100644
> --- a/malloc/arena.c
> +++ b/malloc/arena.c
> @@ -207,7 +207,6 @@ __malloc_fork_unlock_child (void)
>   }
>  
>   #if HAVE_TUNABLES
> -static inline int do_set_mallopt_check (int32_t value);

OK. malloc/malloc.c has the function and uses it there, but we
don't use it here anymore.

>   void
>   TUNABLE_CALLBACK (set_mallopt_check) (tunable_val_t *valp)
>   {
>


--
Cheers,
Carlos.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Remove do_set_mallopt_check prototype

DJ Delorie-2
In reply to this post by H.J. Lu-30
"H.J. Lu" <[hidden email]> writes:
> * malloc/arena.c (do_set_mallopt_check): Removed.

LGTM too
Reviewed-by: DJ Delorie <[hidden email]>