[PATCH] Remote unnecessary declaration of trace_regblock_size

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Remote unnecessary declaration of trace_regblock_size

cbiesinger
From: Christian Biesinger <[hidden email]>

This variable is declared in tracepoint.h, which is already included
by remote.c.

gdb/ChangeLog:

2019-10-10  Christian Biesinger  <[hidden email]>

        * remote.c (remote_target::get_trace_status): Remove declaration of
        trace_regblock_size.
---
 gdb/remote.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gdb/remote.c b/gdb/remote.c
index 21160e13acc..73b510dd395 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13102,14 +13102,13 @@ remote_target::get_trace_status (struct trace_status *ts)
 {
   /* Initialize it just to avoid a GCC false warning.  */
   char *p = NULL;
-  /* FIXME we need to get register block size some other way.  */
-  extern int trace_regblock_size;
   enum packet_result result;
   struct remote_state *rs = get_remote_state ();
 
   if (packet_support (PACKET_qTStatus) == PACKET_DISABLE)
     return -1;
 
+  /* FIXME we need to get register block size some other way.  */
   trace_regblock_size
     = rs->get_remote_arch_state (target_gdbarch ())->sizeof_g_packet;
 
--
2.23.0.700.g56cf767bdb-goog

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Remote unnecessary declaration of trace_regblock_size

Simon Marchi
On 2019-10-12 01:05, [hidden email] wrote:
> From: Christian Biesinger <[hidden email]>
>
> This variable is declared in tracepoint.h, which is already included
> by remote.c.

Remote -> Remove in the title.

Otherwise, that LGTM.

Simon
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Remote unnecessary declaration of trace_regblock_size

Sourceware - gdb-patches mailing list
On Sat, Oct 12, 2019 at 7:31 PM Simon Marchi <[hidden email]> wrote:

>
> On 2019-10-12 01:05, [hidden email] wrote:
> > From: Christian Biesinger <[hidden email]>
> >
> > This variable is declared in tracepoint.h, which is already included
> > by remote.c.
>
> Remote -> Remove in the title.
>
> Otherwise, that LGTM.

Thanks, pushed.

Christian