[PATCH] [PowerPC] Document requirements for VSX feature

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] [PowerPC] Document requirements for VSX feature

Pedro Franco de Carvalho-2
As suggested in
https://sourceware.org/ml/gdb-patches/2018-10/msg00510.html, this
patch changes the documentation for the VSX tdesc feature to make it
clear that the altivec and FPU features are requirements.

gdb/doc/ChangeLog:
YYYY-MM-DD  Pedro Franco de Carvalho  <[hidden email]>

        * gdb.texinfo: Document the altivec and fpu requirements for
        the org.gnu.gdb.power.vsx feature.
---
 gdb/doc/gdb.texinfo | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 9756155a39..944a2c4383 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -43230,11 +43230,13 @@ contain registers @samp{vr0} through @samp{vr31}, @samp{vscr},
 and @samp{vrsave}.
 
 The @samp{org.gnu.gdb.power.vsx} feature is optional.  It should
-contain registers @samp{vs0h} through @samp{vs31h}.  @value{GDBN}
-will combine these registers with the floating point registers
-(@samp{f0} through @samp{f31}) and the altivec registers (@samp{vr0}
-through @samp{vr31}) to present the 128-bit wide registers @samp{vs0}
-through @samp{vs63}, the set of vector registers for POWER7.
+contain registers @samp{vs0h} through @samp{vs31h}.  @value{GDBN} will
+combine these registers with the floating point registers (@samp{f0}
+through @samp{f31}) and the altivec registers (@samp{vr0} through
+@samp{vr31}) to present the 128-bit wide registers @samp{vs0} through
+@samp{vs63}, the set of vector-scalar registers for POWER7.
+Therefore, this feature requires both @samp{org.gnu.gdb.power.fpu} and
+@samp{org.gnu.gdb.power.altivec}.
 
 The @samp{org.gnu.gdb.power.spe} feature is optional.  It should
 contain registers @samp{ev0h} through @samp{ev31h}, @samp{acc}, and
--
2.13.6

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] [PowerPC] Document requirements for VSX feature

Eli Zaretskii
> From: Pedro Franco de Carvalho <[hidden email]>
> Cc: [hidden email]
> Date: Thu,  8 Nov 2018 11:10:41 -0200
>
> As suggested in
> https://sourceware.org/ml/gdb-patches/2018-10/msg00510.html, this
> patch changes the documentation for the VSX tdesc feature to make it
> clear that the altivec and FPU features are requirements.
>
> gdb/doc/ChangeLog:
> YYYY-MM-DD  Pedro Franco de Carvalho  <[hidden email]>
>
> * gdb.texinfo: Document the altivec and fpu requirements for
> the org.gnu.gdb.power.vsx feature.

The only change is the last sentence, right?

The change is okay, but please include the name of the node in the
ChangeLog entry (in parentheses, as if it were the name of a
function).

Thanks.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] [PowerPC] Document requirements for VSX feature

Pedro Franco de Carvalho-2
Eli Zaretskii <[hidden email]> writes:

> The only change is the last sentence, right?

I did also change "vector registers" to "vector-scalar registers" which
is the proper name for them.  Sorry for the confusing diff, I
auto-formatted the paragraph.

> The change is okay, but please include the name of the node in the
> ChangeLog entry (in parentheses, as if it were the name of a
> function).

Ok! I'll change it to "* gdb.texinfo (PowerPC Features):"

> Thanks.

Thank you!

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] [PowerPC] Document requirements for VSX feature

Pedro Franco de Carvalho-2
In reply to this post by Eli Zaretskii

Checked in.  Thanks!

--
Pedro Franco de Carvalho