[PATCH] MIPS/gas: Remove duplicate usage messages

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] MIPS/gas: Remove duplicate usage messages

Sourceware - binutils list mailing list
Option -m[no-]fix-loongson3-llsc appear more than once, this patch
removes one of them.

gas/
        * config/tc-mips.c (md_show_usage): Remove duplicate usage messages.
---
 gas/ChangeLog        | 4 ++++
 gas/config/tc-mips.c | 2 --
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 3371d7b8cf..66795b8367 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,7 @@
+2020-07-12 Rongwei Zhang <[hidden email]>
+
+ * config/tc-mips.c (md_show_usage): Remove duplicate usage messages.
+
 2020-07-11  H.J. Lu  <[hidden email]>
 
  * config/tc-i386.c (output_insn): Check i.xstate to set
diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
index 31acb77d78..5b64b66607 100644
--- a/gas/config/tc-mips.c
+++ b/gas/config/tc-mips.c
@@ -20461,8 +20461,6 @@ MIPS options:\n\
   fprintf (stream, _("\
 -mfix-loongson2f-jump work around Loongson2F JUMP instructions\n\
 -mfix-loongson2f-nop work around Loongson2F NOP errata\n\
--mfix-loongson3-llsc work around Loongson3 LL/SC errata\n\
--mno-fix-loongson3-llsc disable work around Loongson3 LL/SC errata\n\
 -mfix-vr4120 work around certain VR4120 errata\n\
 -mfix-vr4130 work around VR4130 mflo/mfhi errata\n\
 -mfix-24k insert a nop after ERET and DERET instructions\n\
--
2.26.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] MIPS/gas: Remove duplicate usage messages

Maciej W. Rozycki
On Sun, 12 Jul 2020, Rongwei Zhang via Binutils wrote:

> diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c
> index 31acb77d78..5b64b66607 100644
> --- a/gas/config/tc-mips.c
> +++ b/gas/config/tc-mips.c
> @@ -20461,8 +20461,6 @@ MIPS options:\n\
>    fprintf (stream, _("\
>  -mfix-loongson2f-jump work around Loongson2F JUMP instructions\n\
>  -mfix-loongson2f-nop work around Loongson2F NOP errata\n\
> --mfix-loongson3-llsc work around Loongson3 LL/SC errata\n\
> --mno-fix-loongson3-llsc disable work around Loongson3 LL/SC errata\n\

 I think `loongson3' options should come after `loongson2' ones to follow
the alphabetic order and therefore make them easier to find.  This will
complicate the change, because essentially we want the other part moved
over here, but I think it's worth it.

 Overall this help message is a mess and I think the options should get
categorised with appropriate headings added and then sorted alphabetically
within (with any `no-' part ignored for the purpose of sorting).

  Maciej