[PATCH] MIPS: Correct the handling of reserved FCSR bits

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] MIPS: Correct the handling of reserved FCSR bits

Maciej W. Rozycki-4
Hi,

 Reserved bits in the Floating-Point Control and Status Register (FCSR)
should not be implicitly cleared by fedisableexcept or feenableexcept,
there is no reason to.  Among these are the 8 condition codes and one of
the two bits reserved for architecture implementers (bits #22 & #21).

 As to the latter, there is no reason to treat any of them as reserved
either, they should be user controllable and settable via __fpu_control
override as the user sees fit.  For example in processors implemented by
MIPS Technologies, such as the 5Kf or the 24Kf, these bits are used to
change the treatment of denormalised operands and tiny results: bit #22 is
Flush Override (FO) and bit #21 is Flush to Nearest (FN).  They cause
non-IEEE-compliant behaviour, but some programs may have a use for such
modes of operation; the library should not obstruct such use just as it
does not for the architectural Flush to Zero (FS) bit (bit #24).

 Therefore the change adjusts the reserved mask accordingly and also
documents the distinction between bits 22:21 and 20:18.

 No regressions in mips-linux-gnu testing, o32, n64 and n32 ABIs.  OK to
apply?

2013-08-21  Maciej W. Rozycki  <[hidden email]>

        * sysdeps/mips/fpu_control.h: Document bits reserved for
        architecture implementers.
        (_FPU_RESERVED): Clear bit #21.
        * sysdeps/mips/fpu/fedisblxcpt.c (fedisableexcept): Don't clear
        reserved bits.
        * sysdeps/mips/fpu/feenablxcpt.c (feenableexcept): Likewise.

  Maciej

glibc-ports-mips-fpucw-reserved-fix.diff
Index: glibc-fsf-trunk-quilt/ports/sysdeps/mips/fpu_control.h
===================================================================
--- glibc-fsf-trunk-quilt.orig/ports/sysdeps/mips/fpu_control.h 2012-12-12 04:15:35.577266033 +0000
+++ glibc-fsf-trunk-quilt/ports/sysdeps/mips/fpu_control.h 2012-12-12 04:21:05.767771840 +0000
@@ -28,7 +28,8 @@
  *           causing unimplemented operation exception.  This bit is only
  *           available for MIPS III and newer.
  * 23     -> Condition bit
- * 22-18  -> reserved (read as 0, write with 0)
+ * 22-21  -> reserved for architecture implementers
+ * 20-18  -> reserved (read as 0, write with 0)
  * 17     -> cause bit for unimplemented operation
  * 16     -> cause bit for invalid exception
  * 15     -> cause bit for division by zero exception
@@ -84,7 +85,7 @@ extern fpu_control_t __fpu_control;
 #define _FPU_RC_UP      0x2
 #define _FPU_RC_DOWN    0x3
 
-#define _FPU_RESERVED 0xfebc0000  /* Reserved bits in cw */
+#define _FPU_RESERVED 0xfe9c0000  /* Reserved bits in cw */
 
 
 /* The fdlibm code requires strict IEEE double precision arithmetic,
Index: glibc-fsf-trunk-quilt/ports/sysdeps/mips/fpu/fedisblxcpt.c
===================================================================
--- glibc-fsf-trunk-quilt.orig/ports/sysdeps/mips/fpu/fedisblxcpt.c 2012-12-12 04:14:02.946552647 +0000
+++ glibc-fsf-trunk-quilt/ports/sysdeps/mips/fpu/fedisblxcpt.c 2012-12-12 04:21:05.767771840 +0000
@@ -34,7 +34,6 @@ fedisableexcept (int excepts)
   excepts &= FE_ALL_EXCEPT;
 
   new_exc &= ~(excepts << ENABLE_SHIFT);
-  new_exc &= ~_FPU_RESERVED;
   _FPU_SETCW (new_exc);
 
   return old_exc;
Index: glibc-fsf-trunk-quilt/ports/sysdeps/mips/fpu/feenablxcpt.c
===================================================================
--- glibc-fsf-trunk-quilt.orig/ports/sysdeps/mips/fpu/feenablxcpt.c 2012-12-12 04:14:02.946552647 +0000
+++ glibc-fsf-trunk-quilt/ports/sysdeps/mips/fpu/feenablxcpt.c 2012-12-12 04:21:05.767771840 +0000
@@ -34,7 +34,6 @@ feenableexcept (int excepts)
   excepts &= FE_ALL_EXCEPT;
 
   new_exc |= excepts << ENABLE_SHIFT;
-  new_exc &= ~_FPU_RESERVED;
   _FPU_SETCW (new_exc);
 
   return old_exc;
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] MIPS: Correct the handling of reserved FCSR bits

Joseph Myers
On Wed, 21 Aug 2013, Maciej W. Rozycki wrote:

> 2013-08-21  Maciej W. Rozycki  <[hidden email]>
>
> * sysdeps/mips/fpu_control.h: Document bits reserved for
> architecture implementers.
> (_FPU_RESERVED): Clear bit #21.
> * sysdeps/mips/fpu/fedisblxcpt.c (fedisableexcept): Don't clear
> reserved bits.
> * sysdeps/mips/fpu/feenablxcpt.c (feenableexcept): Likewise.

OK.

--
Joseph S. Myers
[hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] MIPS: Correct the handling of reserved FCSR bits

Maciej W. Rozycki-4
On Wed, 21 Aug 2013, Joseph S. Myers wrote:

> > * sysdeps/mips/fpu_control.h: Document bits reserved for
> > architecture implementers.
> > (_FPU_RESERVED): Clear bit #21.
> > * sysdeps/mips/fpu/fedisblxcpt.c (fedisableexcept): Don't clear
> > reserved bits.
> > * sysdeps/mips/fpu/feenablxcpt.c (feenableexcept): Likewise.
>
> OK.

 Applied, thanks.

  Maciej