[PATCH] Fix g++ 9.1 build breakage

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Fix g++ 9.1 build breakage

Sourceware - gdb-patches mailing list
gdb/ChangeLog:

2019-08-21  Christian Biesinger  <[hidden email]>

        * tui/tui-data.h (tui_gen_win_info): Add an =default
        move constructor, required by some GCC versions.
---
 gdb/tui/tui-data.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h
index 6dfea41d49..f43035674d 100644
--- a/gdb/tui/tui-data.h
+++ b/gdb/tui/tui-data.h
@@ -55,6 +55,7 @@ protected:
   virtual void make_window ();
 
 public:
+  tui_gen_win_info (tui_gen_win_info &&) = default;
 
   virtual ~tui_gen_win_info ();
 
--
2.23.0.rc1.153.gdeed80330f-goog

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix g++ 9.1 build breakage

Tom Tromey-2
>>>>> "Christian" == Christian Biesinger via gdb-patches <[hidden email]> writes:

Christian> gdb/ChangeLog:
Christian> 2019-08-21  Christian Biesinger  <[hidden email]>

Christian> * tui/tui-data.h (tui_gen_win_info): Add an =default
Christian> move constructor, required by some GCC versions.

Thank you for doing this.  This is ok.

FYI we discussed this on irc and it apparently could only be reproduced
with gcc 9.1 -- I had tried gcc 8, 9.*2*, and 10.

Tom
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Fix g++ 9.1 build breakage

Sourceware - gdb-patches mailing list
On Wed, Aug 21, 2019 at 3:08 PM Tom Tromey <[hidden email]> wrote:

>
> >>>>> "Christian" == Christian Biesinger via gdb-patches <[hidden email]> writes:
>
> Christian> gdb/ChangeLog:
> Christian> 2019-08-21  Christian Biesinger  <[hidden email]>
>
> Christian>      * tui/tui-data.h (tui_gen_win_info): Add an =default
> Christian>      move constructor, required by some GCC versions.
>
> Thank you for doing this.  This is ok.
>
> FYI we discussed this on irc and it apparently could only be reproduced
> with gcc 9.1 -- I had tried gcc 8, 9.*2*, and 10.

Thanks, pushed.

Christian