[PATCH] Disable -Werror for itbl-lex.o rule

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Disable -Werror for itbl-lex.o rule

Thiemo Seufer
There are still tools in use (e.g. in Debian unstable) which produce
warnings for the itbl-lex code.

Ok to apply?


Thiemo


2005-11-01  Thiemo Seufer  <[hidden email]>

        * Makefile.am: Disable -Werror for the itbl-lex.o rule.
        * Makefile.in: Regenerate.


Index: gas/Makefile.am
===================================================================
RCS file: /cvs/src/src/gas/Makefile.am,v
retrieving revision 1.126
diff -u -p -r1.126 Makefile.am
--- gas/Makefile.am 30 Oct 2005 17:27:33 -0000 1.126
+++ gas/Makefile.am 1 Nov 2005 02:05:46 -0000
@@ -623,7 +623,11 @@ bfin-lex.o: bfin-lex.c bfin-parse.h $(sr
 # The instruction table specification lexical analyzer and parser.
 
 itbl-lex.c: $(srcdir)/itbl-lex.l
+
+# Disable -Werror, if it has been enabled, since old versions of bison/
+# yacc will produce working code which contain compile time warnings.
 itbl-lex.o: itbl-lex.c itbl-parse.h $(srcdir)/itbl-lex.h
+ $(COMPILE) -c $< $(NO_WERROR)
 
 # Disable -Werror, if it has been enabled, since old versions of bison/
 # yacc will produce working code which contain compile time warnings.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Disable -Werror for itbl-lex.o rule

Alan Modra
On Tue, Nov 01, 2005 at 03:10:09AM +0100, Thiemo Seufer wrote:
> There are still tools in use (e.g. in Debian unstable) which produce
> warnings for the itbl-lex code.
>
> Ok to apply?

Hmm, if someone is using CVS, then we expect certain tools to be
available and sufficiently recent.  If on the other hand they are using
a release, then itbl-lex.c and other similar files should already be
generated.  I see that we already make allowance for an old bison with
m68k-parse.c and itbl-parse.c, so I suppose this is OK to apply.

> +
> +# Disable -Werror, if it has been enabled, since old versions of bison/
> +# yacc will produce working code which contain compile time warnings.
>  itbl-lex.o: itbl-lex.c itbl-parse.h $(srcdir)/itbl-lex.h
> + $(COMPILE) -c $< $(NO_WERROR)
>  
>  # Disable -Werror, if it has been enabled, since old versions of bison/
>  # yacc will produce working code which contain compile time warnings.

--
Alan Modra
IBM OzLabs - Linux Technology Centre
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Disable -Werror for itbl-lex.o rule

Daniel Jacobowitz-2
On Tue, Nov 01, 2005 at 01:04:33PM +1030, Alan Modra wrote:

> On Tue, Nov 01, 2005 at 03:10:09AM +0100, Thiemo Seufer wrote:
> > There are still tools in use (e.g. in Debian unstable) which produce
> > warnings for the itbl-lex code.
> >
> > Ok to apply?
>
> Hmm, if someone is using CVS, then we expect certain tools to be
> available and sufficiently recent.  If on the other hand they are using
> a release, then itbl-lex.c and other similar files should already be
> generated.  I see that we already make allowance for an old bison with
> m68k-parse.c and itbl-parse.c, so I suppose this is OK to apply.

Yes please, and this is also gas/1299.

--
Daniel Jacobowitz
CodeSourcery, LLC