[PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.

Marcus Shawcroft-2
This patch ensures that all argument passing registers are saved and
restored on entry to the dynamic linker and resolves BZ #15128.

Regression tested.  Committed to trunk.  Back port to 2.18 branch will follow.

Cheers
/Marcus

glibc-15128.txt (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.

Andrew Pinski-3
On Wed, Dec 18, 2013 at 4:05 AM, Marcus Shawcroft
<[hidden email]> wrote:
> This patch ensures that all argument passing registers are saved and
> restored on entry to the dynamic linker and resolves BZ #15128.
>
> Regression tested.  Committed to trunk.  Back port to 2.18 branch will follow.


There is a bug in this patch:
- stp x8, x9, [sp, #-80]!
+ stp x8, x9, [sp, #-(80+8*16)]!
  cfi_adjust_cfa_offset (80)


You forgot to update the cfi_adjust_cfa_offset to be 80+8*16.

Thanks,
Andrew Pinski

>
> Cheers
> /Marcus
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH, COMMITTED] BZ #15128 [AArch64] Save and restore q0-q7 on entry to dynamic linker.

Marcus Shawcroft-2
On 6 January 2014 22:04, Andrew Pinski <[hidden email]> wrote:

> You forgot to update the cfi_adjust_cfa_offset to be 80+8*16.

Thanks for pointing that out, fix here:
https://sourceware.org/ml/libc-ports/2014-01/msg00018.html

/Marcus