[PATCH] C6X unwinding table generation #2

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] C6X unwinding table generation #2

Paul Brook
Attached is revised[1] patch to implement C6X unwinding table generation.
I believe this and the subsequent patch address the issues raised by Joseph
last time round.

Ok?

Paul

[1] Original patch: http://sourceware.org/ml/binutils/2011-04/msg00097.html

2011-05-03  Paul Brook  <[hidden email]>


        bfd/
        * elf32-tic6x.c (elf32_tic6x_howto_table,
        elf32_tic6x_howto_table_rel, (elf32_tic6x_gc_sweep_hook,
        elf32_tic6x_relocate_section, elf32_tic6x_check_relocs):
        Add R_C6000_EHTYPE.

        gas/
        * config/tc-tic6x.c (s_ehtype): New function.
        (md_pseudo_table): Add "ehtype".
        (tic6x_fix_adjustable, md_apply_fix): BFD_RELOC_C6000_EHTYPE.
        * doc/c-tic6x.texi: Document .ehtype directive.

        ld/testsuite/
        * ld-tic6x/ehtype-reloc-1-rel.d: New test.
        * ld-tic6x/ehtype-reloc-1.d: New test.
        * ld-tic6x/ehtype-reloc-1.s: New test.

0003-unwinder.patch (60K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] C6X unwinding table generation #2

Joseph Myers
On Tue, 3 May 2011, Paul Brook wrote:

> Attached is revised[1] patch to implement C6X unwinding table generation.
> I believe this and the subsequent patch address the issues raised by Joseph
> last time round.
>
> Ok?
>
> Paul
>
> [1] Original patch: http://sourceware.org/ml/binutils/2011-04/msg00097.html
>
> 2011-05-03  Paul Brook  <[hidden email]>
>
>
> bfd/
> * elf32-tic6x.c (elf32_tic6x_howto_table,
[...]

This ChangeLog entry doesn't appear to correspond to the attached patch.

> +  memset(unwind, 0, sizeof(*unwind));

Missing spaces before '(' twice on this line.

> +    case 2: /* B regs.  */
> +      if (reg.num < 16)
> + return reg.num + 16;
> +      else if (reg.num < 32)
> + return (reg.num - 16) + 53;
> +      else
> + return -1;
> +
> +      return reg.num + 16;

This final "return reg.num + 16;" is dead.

> +#define UNWIND_OP2_CANTUNWIND 0x8000

This still appears to be unused (so should be removed).

The patch is OK with those issues fixed.

--
Joseph S. Myers
[hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] C6X unwinding table generation #2

Joseph Myers
On Tue, 3 May 2011, Joseph S. Myers wrote:

> The patch is OK with those issues fixed.

(That is, the C6X parts are OK.  If the target-independent parts are
unchanged from last time, they are covered by Nick's approval.)

--
Joseph S. Myers
[hidden email]