[PATCH] Add an additional test to resolv/tst-resolv-network.c

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Add an additional test to resolv/tst-resolv-network.c

Alexandra Hájková
From: Alexandra Hájková <[hidden email]>

Test for the infinite loop in getnebyname, bug #17630.

ChangeLog:

2018-11-06  Alexandra Hájková  <[hidden email]>

        [BZ #17630]
        * resolv/tst-resolv-network.c: Add test for getnetbyname.

---
 resolv/tst-resolv-network.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/resolv/tst-resolv-network.c b/resolv/tst-resolv-network.c
index 4b862d57e6..735e38d0f8 100644
--- a/resolv/tst-resolv-network.c
+++ b/resolv/tst-resolv-network.c
@@ -149,6 +149,9 @@ handle_code (const struct resolv_response_context *ctx,
           resolv_response_add_data (b, &rrtype, sizeof (rrtype));
         }
       break;
+    case 104:
+      send_ptr (b, qname, qclass, qtype, "host.example");
+      break;
     default:
       FAIL_EXIT1 ("invalid QNAME: %s (code %d)", qname, code);
     }
@@ -257,6 +260,9 @@ do_test (void)
                 "error: TRY_AGAIN\n");
   check_netent ("code103.example", getnetbyname ("code103.example"),
                 "error: NO_RECOVERY\n");
+  /* Test bug #17630.  */
+  check_netent ("code104.example", getnetbyname ("code104.example"),
+                "error: TRY_AGAIN\n");
 
   /* Lookup by address, success cases.  */
   check_reverse (1,
--
2.17.2

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add an additional test to resolv/tst-resolv-network.c

Florian Weimer-5
* Alexandra Hájková:

> From: Alexandra Hájková <[hidden email]>
>
> Test for the infinite loop in getnebyname, bug #17630.

‘getnetbyname’.

Looks good otherwise.

Please also create an wiki account on
<https://sourceware.org/glibc/wiki/>.

Thanks,
Florian