[PATCH] AArch64: Align ENTRY to a cacheline

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] AArch64: Align ENTRY to a cacheline

Wilco Dijkstra-2
Given almost all uses of ENTRY are for string/memory functions,
align ENTRY to a cacheline to simplify things.

OK for commit?

---
diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
index ae269146e3a5eafa563ec53f2d6f45bbef84d444..2d802db00834ed521ffc3d7e7016f1ee161caf7b 100644
--- a/sysdeps/aarch64/sysdep.h
+++ b/sysdeps/aarch64/sysdep.h
@@ -98,7 +98,7 @@ GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI)
 #define ENTRY(name) \
   .globl C_SYMBOL_NAME(name); \
   .type C_SYMBOL_NAME(name),%function; \
-  .align 4; \
+  .p2align 6; \
   C_LABEL(name) \
   cfi_startproc; \
   BTI_C; \
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] AArch64: Align ENTRY to a cacheline

Sourceware - libc-alpha mailing list
On 7/14/20 12:17 PM, Wilco Dijkstra wrote:
> Given almost all uses of ENTRY are for string/memory functions,
> align ENTRY to a cacheline to simplify things.
>
> OK for commit?

It's OK for 2.32 if Szabolcs says OK.
 

> ---
> diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
> index ae269146e3a5eafa563ec53f2d6f45bbef84d444..2d802db00834ed521ffc3d7e7016f1ee161caf7b 100644
> --- a/sysdeps/aarch64/sysdep.h
> +++ b/sysdeps/aarch64/sysdep.h
> @@ -98,7 +98,7 @@ GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI)
>  #define ENTRY(name) \
>    .globl C_SYMBOL_NAME(name); \
>    .type C_SYMBOL_NAME(name),%function; \
> -  .align 4; \
> +  .p2align 6; \
>    C_LABEL(name) \
>    cfi_startproc; \
>    BTI_C; \
>
>


--
Cheers,
Carlos.

Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] AArch64: Align ENTRY to a cacheline

Szabolcs Nagy-2
The 07/14/2020 16:16, Carlos O'Donell wrote:
> On 7/14/20 12:17 PM, Wilco Dijkstra wrote:
> > Given almost all uses of ENTRY are for string/memory functions,
> > align ENTRY to a cacheline to simplify things.
> >
> > OK for commit?
>
> It's OK for 2.32 if Szabolcs says OK.

thanks.
this is ok to commit.

>  
> > ---
> > diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
> > index ae269146e3a5eafa563ec53f2d6f45bbef84d444..2d802db00834ed521ffc3d7e7016f1ee161caf7b 100644
> > --- a/sysdeps/aarch64/sysdep.h
> > +++ b/sysdeps/aarch64/sysdep.h
> > @@ -98,7 +98,7 @@ GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI)
> >  #define ENTRY(name) \
> >    .globl C_SYMBOL_NAME(name); \
> >    .type C_SYMBOL_NAME(name),%function; \
> > -  .align 4; \
> > +  .p2align 6; \
> >    C_LABEL(name) \
> >    cfi_startproc; \
> >    BTI_C; \
> >
> >
>
>
> --
> Cheers,
> Carlos.
>