[PATCH] AArch64 - Add parameter to __mount routine

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] AArch64 - Add parameter to __mount routine

Venkataramanan Kumar-3
Hi Maintainers,

Attached is a small patch which adds a parameter to __mcount routine.

We would like to make the compiler pass the "frompc" address from the function
that calls __mcount during profiling.

ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html

This patch is cross tested in ARMV8 foundation model. No new regressions found.

If it is ok, someone please commit on my behalf.

2013-09-15  Venkataramanan Kumar  <[hidden email]>

        * sysdeps/aarch64/machine-gmon.h (__mcount): Accept parameter and
          pass it to mcount_internal.

regards,
Venkat.

glibc.gprof.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] AArch64 - Add parameter to __mount routine

Marcus
On 15 September 2013 13:45, Venkataramanan Kumar
<[hidden email]> wrote:
> Hi Maintainers,
>
> Attached is a small patch which adds a parameter to __mcount routine.
>
> We would like to make the compiler pass the "frompc" address from the function
> that calls __mcount during profiling.

This is an ABI change, however, given that there is no functioning
profiling solution using the existing interface I don't think that
such a change is a problem.  Does anyone object?

> ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html
>
> This patch is cross tested in ARMV8 foundation model. No new regressions found.
>
> If it is ok, someone please commit on my behalf.

No regressions is a good start. How did you test the the combined
gcc/glibc patches for profiling are working correctly?

/Marcus
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] AArch64 - Add parameter to __mount routine

Venkataramanan Kumar-3
Hi marcus,

On 16 September 2013 17:01, Marcus Shawcroft <[hidden email]> wrote:

> On 15 September 2013 13:45, Venkataramanan Kumar
> <[hidden email]> wrote:
>> Hi Maintainers,
>>
>> Attached is a small patch which adds a parameter to __mcount routine.
>>
>> We would like to make the compiler pass the "frompc" address from the function
>> that calls __mcount during profiling.
>
> This is an ABI change, however, given that there is no functioning
> profiling solution using the existing interface I don't think that
> such a change is a problem.  Does anyone object?
>
>> ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html
>>
>> This patch is cross tested in ARMV8 foundation model. No new regressions found.
>>
>> If it is ok, someone please commit on my behalf.
>
> No regressions is a good start. How did you test the the combined
> gcc/glibc patches for profiling are working correctly?

I am cross compiling some simple tests cases and running them under in
ARMV8 model by invoking the runtime linker.

"/work/builds/gcc-fsf-trunk-patch/sysroot-aarch64-unknown-linux-gnu/lib/ld-linux-aarch64.so.1
--library-path /work/builds/gcc-fsf-trunk-patch/sysroot-aarch64-unknown-linux-gnu/lib64
test.out"

Basically do functional testing for these test cases by checking the
available gprof options.

regards,
Venkat,
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] AArch64 - Add parameter to __mount routine

Marcus
In reply to this post by Venkataramanan Kumar-3
On 15 September 2013 13:45, Venkataramanan Kumar
<[hidden email]> wrote:

> Hi Maintainers,
>
> Attached is a small patch which adds a parameter to __mcount routine.
>
> We would like to make the compiler pass the "frompc" address from the function
> that calls __mcount during profiling.
>
> ref: http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01556.html
>
> This patch is cross tested in ARMV8 foundation model. No new regressions found.
>
> If it is ok, someone please commit on my behalf.
>
> 2013-09-15  Venkataramanan Kumar  <[hidden email]>
>
>         * sysdeps/aarch64/machine-gmon.h (__mcount): Accept parameter and
>           pass it to mcount_internal.
>
> regards,
> Venkat.

Venkat, I've committed  your patch.
Thanks /Marcus
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] AArch64 - Add parameter to __mount routine

Joseph Myers
On Tue, 24 Sep 2013, Marcus Shawcroft wrote:

> Venkat, I've committed  your patch.

Please remember when committing patches for someone else to use git commit
--author="Name <email>" so the patch's author is correctly recorded in the
git logs.

--
Joseph S. Myers
[hidden email]