[PATCH 2/5] Updates d_language_defn to not use macro expansion

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/5] Updates d_language_defn to not use macro expansion

Iain Buclaw
D doesn't have macros, so it makes little sense to use macro_expansion_c.

2014-01-09  Iain Buclaw  <[hidden email]>

        * d-lang.c (d_language_defn): Change macro_expansion_c to
        macro_expansion_no.

---

dlang-p2.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Tom Tromey
>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:

Iain> D doesn't have macros, so it makes little sense to use macro_expansion_c.
Iain> 2014-01-09  Iain Buclaw  <[hidden email]>

Iain>         * d-lang.c (d_language_defn): Change macro_expansion_c to
Iain>         macro_expansion_no.

Iain> @@ -259,8 +259,8 @@ static const struct language_defn d_language_defn =
Iain>    c_value_print, /* Print a top-level value.  */
Iain>    default_read_var_value, /* la_read_var_value */
Iain>    NULL, /* Language specific skip_trampoline.  */
Iain> -  "this",
Iain> -  basic_lookup_symbol_nonlocal,
Iain> +  "this", /* name_of_this */
Iain> +  basic_lookup_symbol_nonlocal,
Iain>    basic_lookup_transparent_type,
Iain>    d_demangle, /* Language specific symbol demangler.  */
Iain>    NULL, /* Language specific

Spurious change.
This patch is ok with this removed.

Tom
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Iain Buclaw
On 9 January 2014 18:15, Tom Tromey <[hidden email]> wrote:

>>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:
>
> Iain> D doesn't have macros, so it makes little sense to use macro_expansion_c.
> Iain> 2014-01-09  Iain Buclaw  <[hidden email]>
>
> Iain>         * d-lang.c (d_language_defn): Change macro_expansion_c to
> Iain>         macro_expansion_no.
>
> Iain> @@ -259,8 +259,8 @@ static const struct language_defn d_language_defn =
> Iain>    c_value_print,         /* Print a top-level value.  */
> Iain>    default_read_var_value,        /* la_read_var_value */
> Iain>    NULL,                          /* Language specific skip_trampoline.  */
> Iain> -  "this",
> Iain> -  basic_lookup_symbol_nonlocal,
> Iain> +  "this",                        /* name_of_this */
> Iain> +  basic_lookup_symbol_nonlocal,
> Iain>    basic_lookup_transparent_type,
> Iain>    d_demangle,                    /* Language specific symbol demangler.  */
> Iain>    NULL,                          /* Language specific
>
> Spurious change.
> This patch is ok with this removed.
>

It was a comment found in every other language file, it was useful
when I was studying how things were set-up.  Can remove it.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Iain Buclaw
On 9 January 2014 18:32, Iain Buclaw <[hidden email]> wrote:
> On 9 January 2014 18:15, Tom Tromey <[hidden email]> wrote:
>>
>> Spurious change.
>> This patch is ok with this removed.
>>
>
> It was a comment found in every other language file, it was useful
> when I was studying how things were set-up.  Can remove it.

Removed and rebased patch.

---

dlang-p2.patch (604 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Tom Tromey
>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:

Iain> Removed and rebased patch.

FAOD this is ok.

Tom
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Iain Buclaw
On 10 January 2014 17:14, Tom Tromey <[hidden email]> wrote:
>>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:
>
> Iain> Removed and rebased patch.
>
> FAOD this is ok.
>
> Tom

Hi,

Is there anything else needed to be done from me?  Just asking as I
noticed a change to the way that requires this patch to be updated.
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Tom Tromey
>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:

Iain> Is there anything else needed to be done from me?  Just asking as I
Iain> noticed a change to the way that requires this patch to be updated.

I wasn't keeping score, but if all the patches are approved, you can
rebase (our git repository rejects merge commits on master), merge to
master, and push.  If a patch needs any changes during the rebase, you
can use your judgment -- if it is just a trivial change, post the
updated patch as an FYI; if it required some work, usually another round
of review is needed.

If you don't have write-after-approval access, now is a good time to get
it :).  Send me email off-list and I will hook you up.

Tom
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Iain Buclaw
On 16 January 2014 14:34, Tom Tromey <[hidden email]> wrote:

>>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:
>
> Iain> Is there anything else needed to be done from me?  Just asking as I
> Iain> noticed a change to the way that requires this patch to be updated.
>
> I wasn't keeping score, but if all the patches are approved, you can
> rebase (our git repository rejects merge commits on master), merge to
> master, and push.  If a patch needs any changes during the rebase, you
> can use your judgment -- if it is just a trivial change, post the
> updated patch as an FYI; if it required some work, usually another round
> of review is needed.
>

It's just trivial, see the change you did to set_main_name (sorry in
advanced for long url link)

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f=gdb/symtab.c;h=a8073b8ef7e8027566949952b9115631e33a5f5f;hp=5e988c88efceebfbc90192151e57938884ce62ea;hb=9e6c82ad4f55d0ff125721b94fa2191f1cc1000a;hpb=6ef55de768d4ab9065bc92aa00d828212c4af4f0

Regards
Iain
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Tom Tromey
>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:

Iain> It's just trivial, see the change you did to set_main_name (sorry in
Iain> advanced for long url link)

Iain> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blobdiff;f=gdb/symtab.c;h=a8073b8ef7e8027566949952b9115631e33a5f5f;hp=5e988c88efceebfbc90192151e57938884ce62ea;hb=9e6c82ad4f55d0ff125721b94fa2191f1cc1000a;hpb=6ef55de768d4ab9065bc92aa00d828212c4af4f0

Yeah, it's fine to just post the updated patch as an FYI before pushing.

Tom
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 2/5] Updates d_language_defn to not use macro expansion

Iain Buclaw
In reply to this post by Tom Tromey
On 10 January 2014 17:14, Tom Tromey <[hidden email]> wrote:
>>>>>> "Iain" == Iain Buclaw <[hidden email]> writes:
>
> Iain> Removed and rebased patch.
>
> FAOD this is ok.
>
> Tom

Thanks, committed to gdb.

Regards
Iain