[PATCH 1/6] RISC-V: Fix libnosys build

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/6] RISC-V: Fix libnosys build

Kito Cheng-2


0001-RISC-V-Fix-libnosys-build.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/6] RISC-V: Fix libnosys build

Jim Wilson-2
FYI Patches 2 through 6 are already in the github riscv/riscv-newlib
tree, which is the tree that most RISC-V developers currently use, via
the riscv/riscv-gnu-toolchain project.  It would be good to have them in
the upstream sourceware.org tree too for consistency.  I'm trying to do
as much work as possible in the upstream trees, but missing patches make
this tricky.  Patch 1 appears to be new.  The patches all look
reasonable to me.  Patch 5 can work only if patch 6 is also added.  This
was a mistake on my part, not understanding how git submodule worked at
the time, and hence not realizing that I didn't have the most recent
version of the sources checked out.

Jim
Reply | Threaded
Open this post in threaded view
|

Re: [patches] Re: [PATCH 1/6] RISC-V: Fix libnosys build

Kito Cheng-2
Hi Jim:

Yeah, it's a little divergence between github and upstream during clean up
for upstream, I plan to sync it after 2.6 released.

Patch 1 didn't appear in github is my mistake, I'll put into
riscv/riscv-newlib tree soon.

Thanks for your review :)

On Tue, Dec 19, 2017 at 12:50 PM, Jim Wilson <[hidden email]> wrote:

> FYI Patches 2 through 6 are already in the github riscv/riscv-newlib tree,
> which is the tree that most RISC-V developers currently use, via the
> riscv/riscv-gnu-toolchain project.  It would be good to have them in the
> upstream sourceware.org tree too for consistency.  I'm trying to do as
> much work as possible in the upstream trees, but missing patches make this
> tricky.  Patch 1 appears to be new.  The patches all look reasonable to
> me.  Patch 5 can work only if patch 6 is also added.  This was a mistake on
> my part, not understanding how git submodule worked at the time, and hence
> not realizing that I didn't have the most recent version of the sources
> checked out.
>
> Jim
>
> --
> You received this message because you are subscribed to the Google Groups
> "RISC-V Patches" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [hidden email].
> To post to this group, send email to [hidden email].
> Visit this group at https://groups.google.com/a/gr
> oups.riscv.org/group/patches/.
> To view this discussion on the web visit https://groups.google.com/a/gr
> oups.riscv.org/d/msgid/patches/570f55dd-0f86-8fc9-7704-b57a8
> 62cbab1%40sifive.com.
> For more options, visit https://groups.google.com/a/gr
> oups.riscv.org/d/optout.
>
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/6] RISC-V: Fix libnosys build

Jim Wilson-2
In reply to this post by Kito Cheng-2
It turns out that Kito is already newlib riscv maintainer, so can
self-approve the patches.  Also, Kito does not have write access, but I
do, so I can commit the patches for him.

Committed.

Jim