[PATCH 1/4]: microblaze: remove duplicate prototypes

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/4]: microblaze: remove duplicate prototypes

Gunther Nikl-2
The microblaze target header duplicates prototypes already provided by tc.h.


2020-XX-XX  Gunther Nikl  <[hidden email]>

        * config/tc-microblaze.h (md_begin, md_assemble, md_undefined_symbol,
        md_show_usage, md_convert_frag, md_operand, md_number_to_chars,
        md_estimate_size_before_relax, md_section_align, tc_gen_reloc,
        md_apply_fix3): Delete prototypes.

diff --git a/gas/config/tc-microblaze.h b/gas/config/tc-microblaze.h
index a84e7e4035..35f53a0547 100644
--- a/gas/config/tc-microblaze.h
+++ b/gas/config/tc-microblaze.h
@@ -96,21 +96,10 @@ extern const struct relax_type md_relax_table[];
 
 #include "write.h"        /* For definition of fixS */
 
-extern void      md_begin            (void);
-extern void      md_assemble         (char *);
-extern symbolS * md_undefined_symbol (char *);
-extern void      md_show_usage       (FILE *);
-extern void      md_convert_frag               (bfd *, segT, fragS *);
-extern void      md_operand                    (expressionS *);
-extern int       md_estimate_size_before_relax (fragS *, segT);
-extern void      md_number_to_chars            (char *, valueT, int);
-extern valueT    md_section_align              (segT, valueT);
 extern long      md_pcrel_from_section         (fixS *, segT);
-extern arelent * tc_gen_reloc                  (asection *, fixS *);
 extern void cons_fix_new_microblaze       (fragS *, int, int,
  expressionS *,
  bfd_reloc_code_real_type);
-extern void md_apply_fix3       (fixS *, valueT *, segT);
 
 #define EXTERN_FORCE_RELOC -1
 
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH 1/4]: microblaze: remove duplicate prototypes

Michael Eager-2
On 4/7/20 3:01 AM, Gunther Nikl wrote:

> The microblaze target header duplicates prototypes already provided by tc.h.
>
>
> 2020-XX-XX  Gunther Nikl  <[hidden email]>
>
> * config/tc-microblaze.h (md_begin, md_assemble, md_undefined_symbol,
> md_show_usage, md_convert_frag, md_operand, md_number_to_chars,
> md_estimate_size_before_relax, md_section_align, tc_gen_reloc,
> md_apply_fix3): Delete prototypes.
>
> diff --git a/gas/config/tc-microblaze.h b/gas/config/tc-microblaze.h
> index a84e7e4035..35f53a0547 100644
> --- a/gas/config/tc-microblaze.h
> +++ b/gas/config/tc-microblaze.h
> @@ -96,21 +96,10 @@ extern const struct relax_type md_relax_table[];
>  
>   #include "write.h"        /* For definition of fixS */
>  
> -extern void      md_begin            (void);
> -extern void      md_assemble         (char *);
> -extern symbolS * md_undefined_symbol (char *);
> -extern void      md_show_usage       (FILE *);
> -extern void      md_convert_frag               (bfd *, segT, fragS *);
> -extern void      md_operand                    (expressionS *);
> -extern int       md_estimate_size_before_relax (fragS *, segT);
> -extern void      md_number_to_chars            (char *, valueT, int);
> -extern valueT    md_section_align              (segT, valueT);
>   extern long      md_pcrel_from_section         (fixS *, segT);
> -extern arelent * tc_gen_reloc                  (asection *, fixS *);
>   extern void cons_fix_new_microblaze       (fragS *, int, int,
>   expressionS *,
>   bfd_reloc_code_real_type);
> -extern void md_apply_fix3       (fixS *, valueT *, segT);
>  
>   #define EXTERN_FORCE_RELOC -1

OK to apply.