NEWS update about buffer overflow detection with GCC 10

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

NEWS update about buffer overflow detection with GCC 10

Sourceware - libc-alpha mailing list
If this is in line with Glibc's practices, I'd like to add a brief
mention in the NEWS of file the recent enhancement to annotate some
Glibc APIs with GCC 10 attribute access.

How does the paragraph below sound?

Martin


diff --git a/NEWS b/NEWS
index 141078c319..5c5f099566 100644
--- a/NEWS
+++ b/NEWS
@@ -23,6 +23,11 @@ Major new features:
    toolchains.  It is recommended to use GCC 8 or newer when testing
    this option.

+* To help detect buffer overflows and other out-of-bounds accesses
+  a number of APIs have been annotated with GCC attribute accesss.  This
+  allows GCC 10 to issue warnings for a greater subset such accesses
+  than previous versions.
+
  Deprecated and removed features, and other changes affecting
compatibility:

  * The deprecated <sys/sysctl.h> header and the sysctl function have been
Reply | Threaded
Open this post in threaded view
|

Re: NEWS update about buffer overflow detection with GCC 10

Sourceware - libc-alpha mailing list
Martin Sebor via Libc-alpha <[hidden email]> writes:

> +  a number of APIs have been annotated with GCC attribute accesss.  This
> +  allows GCC 10 to issue warnings for a greater subset such accesses
> +  than previous versions.

"greater subset *of*"?

--
Adam Sampson <[hidden email]>                         <http://offog.org/>
Reply | Threaded
Open this post in threaded view
|

Re: NEWS update about buffer overflow detection with GCC 10

Sourceware - libc-alpha mailing list
On Wed, 2020-05-13 at 00:53 +0100, Adam Sampson via Libc-alpha wrote:
> Martin Sebor via Libc-alpha <[hidden email]> writes:
>
> > +  a number of APIs have been annotated with GCC attribute accesss.  This
> > +  allows GCC 10 to issue warnings for a greater subset such accesses
> > +  than previous versions.
>
> "greater subset *of*"?
Seems fine after that minor edit.

jeff

Reply | Threaded
Open this post in threaded view
|

Re: NEWS update about buffer overflow detection with GCC 10

Sourceware - libc-alpha mailing list
In reply to this post by Sourceware - libc-alpha mailing list
Let me put the question differently: is anyone opposed to making this
NEWS update?  Or are there suggestions for phrasing it differently?

Marti

On 5/12/20 1:04 PM, Martin Sebor wrote:

> If this is in line with Glibc's practices, I'd like to add a brief
> mention in the NEWS of file the recent enhancement to annotate some
> Glibc APIs with GCC 10 attribute access.
>
> How does the paragraph below sound?
>
> Martin
>
>
> diff --git a/NEWS b/NEWS
> index 141078c319..5c5f099566 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -23,6 +23,11 @@ Major new features:
>     toolchains.  It is recommended to use GCC 8 or newer when testing
>     this option.
>
> +* To help detect buffer overflows and other out-of-bounds accesses
> +  a number of APIs have been annotated with GCC attribute accesss.  This
> +  allows GCC 10 to issue warnings for a greater subset such accesses
> +  than previous versions.
> +
>   Deprecated and removed features, and other changes affecting
> compatibility:
>
>   * The deprecated <sys/sysctl.h> header and the sysctl function have been

Reply | Threaded
Open this post in threaded view
|

Re: NEWS update about buffer overflow detection with GCC 10

Paul Eggert
On 5/18/20 5:29 PM, Martin Sebor via Libc-alpha wrote:
>
> +* To help detect buffer overflows and other out-of-bounds accesses
> +  a number of APIs have been annotated with GCC attribute accesss.  This
> +  allows GCC 10 to issue warnings for a greater subset such accesses
> +  than previous versions.

I suggest rewording lines 2-3 as follows. (This is just English-language
wordsmithing; the point of the NEWS item sounds good to me.)

   several APIs have been annotated with the GCC 'access' attribute.
   This should help GCC 10 issue better warnings.
Reply | Threaded
Open this post in threaded view
|

Re: NEWS update about buffer overflow detection with GCC 10

Sourceware - libc-alpha mailing list
On 5/18/20 6:35 PM, Paul Eggert wrote:

> On 5/18/20 5:29 PM, Martin Sebor via Libc-alpha wrote:
>>
>> +* To help detect buffer overflows and other out-of-bounds accesses
>> +  a number of APIs have been annotated with GCC attribute accesss.  This
>> +  allows GCC 10 to issue warnings for a greater subset such accesses
>> +  than previous versions.
>
> I suggest rewording lines 2-3 as follows. (This is just English-language
> wordsmithing; the point of the NEWS item sounds good to me.)
>
>    several APIs have been annotated with the GCC 'access' attribute.
>    This should help GCC 10 issue better warnings.

Sounds good.  I just pushed the updated change.

Thank you!
Martin