Fwd: [PATCH]: fix native Linux/Alpha gdb build

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Fwd: [PATCH]: fix native Linux/Alpha gdb build

Christian Groessler-2
I had erroneously sent this to the binutils list. But it's a gdb change...

regards,
chris



-------- Forwarded Message --------
Subject: [PATCH]: fix native Linux/Alpha gdb build
Date: Thu, 12 Sep 2019 00:31:58 +0200
From: Christian Groessler <[hidden email]>
To: Binutils Development <[hidden email]>



Hi,

I was getting the following error:

...
   CXX    alpha-linux-nat.o
alpha-linux-nat.c: In member function 'virtual CORE_ADDR
alpha_linux_nat_target::register_u_offset(gdbarch*, int, int)':
alpha-linux-nat.c:93:16: error: 'gdbarch_pc_regnum' was not declared in
this scope
    if (regno == gdbarch_pc_regnum (gdbarch))
                 ^~~~~~~~~~~~~~~~~
alpha-linux-nat.c:93:16: note: suggested alternative: 'gdbarch_info'
    if (regno == gdbarch_pc_regnum (gdbarch))
                 ^~~~~~~~~~~~~~~~~
                 gdbarch_info
alpha-linux-nat.c:97:15: error: 'gdbarch_fp0_regnum' was not declared in
this scope
    if (regno < gdbarch_fp0_regnum (gdbarch))
                ^~~~~~~~~~~~~~~~~~
alpha-linux-nat.c:97:15: note: suggested alternative: 'gdbarch_info'
    if (regno < gdbarch_fp0_regnum (gdbarch))
                ^~~~~~~~~~~~~~~~~~
                gdbarch_info
make[2]: *** [Makefile:1638: alpha-linux-nat.o] Error 1
make[2]: Leaving directory '/home/chris/tmp/binutils-gdb/gdb'


OK to apply?

regards,
chris



----------------------


 From bc54a0d57bb658040527c29ee33c8472586fa8c6 Mon Sep 17 00:00:00 2001
From: Christian Groessler <[hidden email]>
Date: Wed, 11 Sep 2019 22:19:45 +0000
Subject: [PATCH] Fix native build on Linux/Alpha.

2019-09-12  Christian Groessler  <[hidden email]>

        * alpha-linux-nat.c: Include gdbarch.h.
---
  gdb/ChangeLog         | 4 ++++
  gdb/alpha-linux-nat.c | 1 +
  2 files changed, 5 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4c354700c4..74411c24de 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-09-12  Christian Groessler  <[hidden email]>
+
+       * alpha-linux-nat.c: Include gdbarch.h.
+
  2019-09-11  Christian Biesinger  <[hidden email]>

         * auto-load.c (auto_load_expand_dir_vars): Update.
diff --git a/gdb/alpha-linux-nat.c b/gdb/alpha-linux-nat.c
index 18806971a7..9f83ad7cc6 100644
--- a/gdb/alpha-linux-nat.c
+++ b/gdb/alpha-linux-nat.c
@@ -22,6 +22,7 @@
  #include "linux-nat-trad.h"

  #include "alpha-tdep.h"
+#include "gdbarch.h"

  #include "nat/gdb_ptrace.h"
  #include <alpha/ptrace.h>

--
2.21.0


Reply | Threaded
Open this post in threaded view
|

Re: Fwd: [PATCH]: fix native Linux/Alpha gdb build

Simon Marchi-4
On 2019-09-11 7:47 p.m., Christian Groessler wrote:
> I had erroneously sent this to the binutils list. But it's a gdb change...
>
> regards,
> chris

Hi Christian,

I've pushed this patch, thanks.

Out of curiosity, do you happen to have a DEC Alpha running in your basement?

Simon
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: [PATCH]: fix native Linux/Alpha gdb build

Christian Groessler-2
On 9/18/19 9:21 PM, Simon Marchi wrote:

> I've pushed this patch, thanks.

Thanks.

> Out of curiosity, do you happen to have a DEC Alpha running in your basement?

Yes. An ES45. But not in the basement, but in the garage.

regards,
chris