Fix for test gnu/testlet/java/io/File/security.java

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix for test gnu/testlet/java/io/File/security.java

Pavel Tisnovsky
Greetings,

I'd like to fix the Mauve test "gnu/testlet/java/io/File/security.java" to
properly close & delete all its work files and directories in the right order.

The fix is very simple:


--- mauve/gnu/testlet/java/io/File/security.java        2010-11-15
21:56:26.000000000 +0100
+++ mauve/gnu/testlet/java/io/File/security.java        2011-08-12
17:15:54.000000000 +0200
@@ -526,8 +526,9 @@
       if (tmpfile2 != null) tmpfile2.delete();
       if (tf1 != null) tf1.delete();
       if (tf2 != null) tf2.delete();
-      if (tmpdir != null) tmpdir.delete();
+      if (tmpdir3 != null) tmpdir3.delete();
       if (tmpdir2 != null) tmpdir2.delete();
+      if (tmpdir != null) tmpdir.delete();
     }
   }
 }


Is it possible to push this fix to CVS please?

Thank you in advance,
Pavel Tisnovsky
Reply | Threaded
Open this post in threaded view
|

Re: Fix for test gnu/testlet/java/io/File/security.java

ahughes-2
On 13:48 Tue 16 Aug     , Pavel Tisnovsky wrote:

> Greetings,
>
> I'd like to fix the Mauve test "gnu/testlet/java/io/File/security.java" to
> properly close & delete all its work files and directories in the right order.
>
> The fix is very simple:
>
>
> --- mauve/gnu/testlet/java/io/File/security.java        2010-11-15
> 21:56:26.000000000 +0100
> +++ mauve/gnu/testlet/java/io/File/security.java        2011-08-12
> 17:15:54.000000000 +0200
> @@ -526,8 +526,9 @@
>        if (tmpfile2 != null) tmpfile2.delete();
>        if (tf1 != null) tf1.delete();
>        if (tf2 != null) tf2.delete();
> -      if (tmpdir != null) tmpdir.delete();
> +      if (tmpdir3 != null) tmpdir3.delete();
>        if (tmpdir2 != null) tmpdir2.delete();
> +      if (tmpdir != null) tmpdir.delete();
>      }
>    }
>  }
>
>
> Is it possible to push this fix to CVS please?
>
> Thank you in advance,
> Pavel Tisnovsky

Yes, looks fine.
--
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37