[FYI] Fix gdb build on macOS

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[FYI] Fix gdb build on macOS

Tom Tromey-4
Internal testing showed that the macOS port did not build.  The
breakage was caused by the patch to remove the gdbarch.h include from
defs.h.  This patch fixes the problem.

gdb/ChangeLog
2019-08-14  Tom Tromey  <[hidden email]>

        * darwin-nat.c: Include gdbarch.h.
        * darwin-nat-info.c: Include gdbarch.h.
---
 gdb/ChangeLog         | 5 +++++
 gdb/darwin-nat-info.c | 1 +
 gdb/darwin-nat.c      | 1 +
 3 files changed, 7 insertions(+)

diff --git a/gdb/darwin-nat-info.c b/gdb/darwin-nat-info.c
index 103ac2a9773..4469cd52136 100644
--- a/gdb/darwin-nat-info.c
+++ b/gdb/darwin-nat-info.c
@@ -34,6 +34,7 @@
 #include "value.h"
 #include "gdbcmd.h"
 #include "inferior.h"
+#include "gdbarch.h"
 
 #include <sys/sysctl.h>
 
diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index f890e13944c..8f71def069d 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -37,6 +37,7 @@
 #include "arch-utils.h"
 #include "bfd.h"
 #include "bfd/mach-o.h"
+#include "gdbarch.h"
 
 #include <copyfile.h>
 #include <sys/ptrace.h>
--
2.20.1

Reply | Threaded
Open this post in threaded view
|

[committed][gdb] Fix gdb build on mips64-linux

Tom de Vries
[ was: [FYI] Fix gdb build on macOS ]

On 14-08-19 16:41, Tom Tromey wrote:
> Internal testing showed that the macOS port did not build.  The
> breakage was caused by the patch to remove the gdbarch.h include from
> defs.h.  This patch fixes the problem.
>
> gdb/ChangeLog
> 2019-08-14  Tom Tromey  <[hidden email]>
>
> * darwin-nat.c: Include gdbarch.h.
> * darwin-nat-info.c: Include gdbarch.h.

Committed similar for linux-nat-trad.c.

Thanks,
- Tom

[gdb] Fix gdb build on mips64-linux

When compiling for mips64-linux, we get:
...
src/gdb/linux-nat-trad.c:139:12: error: ‘gdbarch_num_regs’ was not declared \
  in this scope
  139 |   regnum < gdbarch_num_regs (regcache->arch ());
...

Fix this by including gdbarch.h in linux-nat-trad.c, similar to commit
b1c896b365 "Fix gdb build on macOS".

Build on mips64-linux.

gdb/ChangeLog:

2019-08-15  Tom de Vries  <[hidden email]>

        * linux-nat-trad.c: Include gdbarch.h.

---
 gdb/linux-nat-trad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/linux-nat-trad.c b/gdb/linux-nat-trad.c
index 04507e8041..c6208dccdb 100644
--- a/gdb/linux-nat-trad.c
+++ b/gdb/linux-nat-trad.c
@@ -22,6 +22,7 @@
 
 #include "nat/gdb_ptrace.h"
 #include "inf-ptrace.h"
+#include "gdbarch.h"
 
 /* Fetch register REGNUM from the inferior.  */