Close bug 11615?

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Close bug 11615?

Ondřej Bílka
Hi David,

Following patch is for handling broken binaries on mips with RLD_MAP set
to 0. This was caused by bug in binutils which was fixed two years ago,
see. I wanted to be sure that it is no longer relevant.

https://sourceware.org/bugzilla/show_bug.cgi?id=11615

diff --git a/sysdeps/mips/dl-machine.h b/sysdeps/mips/dl-machine.h
index 123b4d6..3bed59c 100644
--- a/sysdeps/mips/dl-machine.h
+++ b/sysdeps/mips/dl-machine.h
@@ -70,7 +70,8 @@
 /* If there is a DT_MIPS_RLD_MAP entry in the dynamic section, fill it
in
    with the run-time address of the r_debug structure  */
 #define ELF_MACHINE_DEBUG_SETUP(l,r) \
-do { if ((l)->l_info[DT_MIPS (RLD_MAP)]) \
+do { if ((l)->l_info[DT_MIPS (RLD_MAP)] && \
+ (l)->l_info[DT_MIPS (RLD_MAP)]->d_un.d_ptr) \
        *(ElfW(Addr) *)((l)->l_info[DT_MIPS (RLD_MAP)]->d_un.d_ptr) = \
        (ElfW(Addr)) (r); \
    } while (0)

Reply | Threaded
Open this post in threaded view
|

Re: Close bug 11615?

David Miller-13
From: Ondřej Bílka <[hidden email]>
Date: Sat, 12 Oct 2013 22:05:24 +0200

> Following patch is for handling broken binaries on mips with RLD_MAP set
> to 0. This was caused by bug in binutils which was fixed two years ago,
> see. I wanted to be sure that it is no longer relevant.
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=11615

The binutils bug has been fixed for at least 2 years.  I'd say
it's better not to add this check.