[Bug tui/24722] New: deleting a breakpoint does not make the "b" disappear

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug tui/24722] New: deleting a breakpoint does not make the "b" disappear

fweimer at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24722

            Bug ID: 24722
           Summary: deleting a breakpoint does not make the "b" disappear
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

Enter the TUI.  Make a breakpoint somewhere in the visible
source code, and notice that a "b" appears in the margin.
Now, "delete" the breakpoint -- the "b" remains.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug tui/24722] deleting a breakpoint does not make the "b" disappear

fweimer at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24722

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
I have a patch.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug tui/24722] deleting a breakpoint does not make the "b" disappear

fweimer at redhat dot com
In reply to this post by fweimer at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24722

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=0807ab7b88fa5ffb138ba1ee22b33d26e239de2f

commit 0807ab7b88fa5ffb138ba1ee22b33d26e239de2f
Author: Tom Tromey <[hidden email]>
Date:   Sun Jun 23 21:25:46 2019 -0600

    Remove deleted breakpoint from TUI display

    PR tui/24722 points out that deleting a breakpoint does not cause the
    "b" to be removed from the breakpoint display.  The issue here was
    that the breakpoint still exists at the moment the breakpoint-deleted
    observer is notified.  This fixes the problem by specially handling
    the case where a breakpoint is being removed.

    gdb/ChangeLog
    2019-07-17  Tom Tromey  <[hidden email]>

        PR tui/24722:
        * tui/tui-winsource.h (tui_update_all_breakpoint_info)
        (tui_update_breakpoint_info): Add "being_deleted" parameter.
        * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
        (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
        (tui_update_breakpoint_info): Likewise.
        * tui/tui-hooks.c (tui_event_create_breakpoint)
        (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
        Update.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug tui/24722] deleting a breakpoint does not make the "b" disappear

fweimer at redhat dot com
In reply to this post by fweimer at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24722

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
It turns out that patch is not sufficient :(
so I am leaving this open.

--
You are receiving this mail because:
You are on the CC list for the bug.