[Bug translator/2140] New: 'delete' operator doesn't work on all variations

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug translator/2140] New: 'delete' operator doesn't work on all variations

glaubitz at physik dot fu-berlin.de
see http://sourceware.org/ml/systemtap/2006-q1/msg00051.html

Presently, use of the 'delete' operator does not generate valid code for all
possible variations.  It is agreed that 'delete' should work on indices of maps
or on the entire map, whether the map value-type is string, integer, or stat.
It should probably also work as a reset for scalar stat variables as well, since
there's no other way to clear them.

It's debatable whether 'delete' should act as a reset for scalar strings and
integers, but since no-one seems to have a strong opinion against this, we
should probably add it for consistency.

See src/testsuite/buildok/delete.stp for a testcase which currently fails.

--
           Summary: 'delete' operator doesn't work on all variations
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: translator
        AssignedTo: systemtap at sources dot redhat dot com
        ReportedBy: joshua dot i dot stone at intel dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2140

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
Reply | Threaded
Open this post in threaded view
|

[Bug translator/2140] 'delete' operator doesn't work on all variations

glaubitz at physik dot fu-berlin.de

------- Additional Comments From joshua dot i dot stone at intel dot com  2006-01-12 01:19 -------
Created an attachment (id=824)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=824&action=view)
first crack at a fix

Here's a patch that I thought would fix this, but it's not quite there.

There seems to be a disconnect with the way temporaries are defined - e.g. it
generates a Stat temporary (illegal), but I don't understand why.  Nothing in
the probe body tries to assign a Stat to a temp.  In fact, it generates temps
up to __tmp26, even though the highest I see referenced in the actual probe is
__tmp23.

--


http://sourceware.org/bugzilla/show_bug.cgi?id=2140

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
Reply | Threaded
Open this post in threaded view
|

[Bug translator/2140] 'delete' operator doesn't work on all variations

glaubitz at physik dot fu-berlin.de
In reply to this post by glaubitz at physik dot fu-berlin.de

------- Additional Comments From fche at redhat dot com  2006-01-16 18:59 -------
*** Bug 2157 has been marked as a duplicate of this bug. ***

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hunt at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2140

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
Reply | Threaded
Open this post in threaded view
|

[Bug translator/2140] 'delete' operator doesn't work on all variations

glaubitz at physik dot fu-berlin.de
In reply to this post by glaubitz at physik dot fu-berlin.de

------- Additional Comments From joshua dot i dot stone at intel dot com  2006-01-16 23:44 -------
Committed in CVS

translate.cxx   1.94
runtime/stat.c  1.4

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=2140

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.