[Bug tapsets/24343] New: Some syscall.*.return missing name and retstr variables

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug tapsets/24343] New: Some syscall.*.return missing name and retstr variables

Martin.Jansa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24343

            Bug ID: 24343
           Summary: Some syscall.*.return missing name and retstr
                    variables
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tapsets
          Assignee: systemtap at sourceware dot org
          Reporter: wcohen at redhat dot com
  Target Milestone: ---

When reviewing test results noticed that
/testsuite/systemtap.examples/process/strace.stp had the following warning:

WARNING: never-assigned local variable 'retstr' (similar: argstr, status, name,
_target_set, thread_argstr): identifier 'retstr' at strace.stp:49:38
 source:     report(name,thread_argstr[tid()],retstr)

Noticed that a number of the syscall.*.return and nd_syscall.*.return are
missing retstr variable.  Below is the list from x86_64 of syscalls missing
retstr.

$ stap -L 'syscall.*.return' |grep -v retstr
syscall.accept.return
syscall.accept4.return
syscall.bind.return
syscall.compat_signalfd.return _entry_tvar_tid:long
syscall.compat_sys_msgctl.return _entry_tvar_tid:long
syscall.compat_sys_msgrcv.return _entry_tvar_tid:long
syscall.compat_sys_msgsnd.return _entry_tvar_tid:long
syscall.compat_sys_recvmsg.return _entry_tvar_tid:long
syscall.compat_sys_semctl.return _entry_tvar_tid:long
syscall.compat_sys_semtimedop.return _entry_tvar_tid:long
syscall.compat_sys_sendmsg.return _entry_tvar_tid:long
syscall.compat_sys_shmat.return _entry_tvar_tid:long
syscall.compat_sys_shmctl.return _entry_tvar_tid:long
syscall.connect.return
syscall.epoll_create.return _entry_tvar_tid:long
syscall.getpeername.return
syscall.getsockname.return
syscall.getsockopt.return
syscall.listen.return
syscall.msgget.return
syscall.pipe.return _entry_tvar_tid:long
syscall.recv.return
syscall.recvfrom.return
syscall.recvmsg.return
syscall.semget.return
syscall.semop.return
syscall.send.return
syscall.sendmmsg.return
syscall.sendmsg.return
syscall.sendto.return
syscall.setsockopt.return
syscall.shmdt.return
syscall.shmget.return
syscall.shutdown.return
syscall.signalfd.return _entry_tvar_tid:long
syscall.socket.return
syscall.socketpair.return
syscall.wait4.return _entry_tvar_tid:long

Some are syscall.*.return also missing name variable:

$  stap -L "syscall.*.return"|grep -v name
syscall.accept.return
syscall.accept4.return
syscall.bind.return
syscall.compat_signalfd.return _entry_tvar_tid:long
syscall.compat_sys_msgctl.return _entry_tvar_tid:long
syscall.compat_sys_msgrcv.return _entry_tvar_tid:long
syscall.compat_sys_msgsnd.return _entry_tvar_tid:long
syscall.compat_sys_recvmsg.return _entry_tvar_tid:long
syscall.compat_sys_semctl.return _entry_tvar_tid:long
syscall.compat_sys_semtimedop.return _entry_tvar_tid:long
syscall.compat_sys_sendmsg.return _entry_tvar_tid:long
syscall.compat_sys_shmat.return _entry_tvar_tid:long
syscall.compat_sys_shmctl.return _entry_tvar_tid:long
syscall.connect.return
syscall.epoll_create.return _entry_tvar_tid:long
syscall.getsockopt.return
syscall.listen.return
syscall.msgget.return
syscall.pipe.return _entry_tvar_tid:long
syscall.recv.return
syscall.recvfrom.return
syscall.recvmsg.return
syscall.semget.return
syscall.semop.return
syscall.send.return
syscall.sendmmsg.return
syscall.sendmsg.return
syscall.sendto.return
syscall.setsockopt.return
syscall.shmdt.return
syscall.shmget.return
syscall.shutdown.return
syscall.signalfd.return _entry_tvar_tid:long
syscall.socket.return
syscall.socketpair.return
syscall.wait4.return _entry_tvar_tid:long

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug tapsets/24343] Some syscall.*.return missing name and retstr variables

Martin.Jansa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24343

Sagar Patel <sapatel at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |sapatel at redhat dot com
         Resolution|---                         |FIXED
           Assignee|systemtap at sourceware dot org    |sapatel at redhat dot com

--- Comment #1 from Sagar Patel <sapatel at redhat dot com> ---
Fixed in commit 4f4f173ad325b2e2e6228a2fd109953769a7d905.

--
You are receiving this mail because:
You are the assignee for the bug.