[Bug runtime/25266] New: Log configure command output when compiling modules

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug runtime/25266] New: Log configure command output when compiling modules

tim@mr-dog.net
https://sourceware.org/bugzilla/show_bug.cgi?id=25266

            Bug ID: 25266
           Summary: Log configure command output when compiling modules
           Product: systemtap
           Version: unspecified
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: runtime
          Assignee: systemtap at sourceware dot org
          Reporter: craig.ringer at 2ndquadrant dot com
  Target Milestone: ---

The runtime configure commands' output is not logged anywhere. From the
generated Makefile for module builds:

~~~
        @if $(CHECK_BUILD)
$(SYSTEMTAP_RUNTIME)/linux/autoconf-linux-sched_headers.c > /dev/null 2>&1;
then echo "#define STAPCONF_LINUX_SCHED_HEADERS 1"; fi >> $@
~~~

all output is sent to /dev/null .

This made diagnosis rather harder in #25265

I suggest redirection of stdout to stderr instead, and bracketing it with an
echo. Like

~~~
        @echo Runtime configure test linux/autoconf-linux-sched_headers.c for
STAPCONF_LINUX_SCHED_HEADERS:
        @if $(CHECK_BUILD)
$(SYSTEMTAP_RUNTIME)/linux/autoconf-linux-sched_headers.c 1>&2; then echo
"#define STAPCONF_LINUX_SCHED_HEADERS 1"; echo "yes"; else echo "no"; fi >> $@
~~~

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug runtime/25266] Log configure command output when compiling modules

tim@mr-dog.net
https://sourceware.org/bugzilla/show_bug.cgi?id=25266

Craig Ringer <craig.ringer at 2ndquadrant dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=25265

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug runtime/25266] Log configure command output when compiling modules

tim@mr-dog.net
In reply to this post by tim@mr-dog.net
https://sourceware.org/bugzilla/show_bug.cgi?id=25266

Craig Ringer <craig.ringer at 2ndquadrant dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=25267

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug runtime/25266] Log configure command output when compiling modules

tim@mr-dog.net
In reply to this post by tim@mr-dog.net
https://sourceware.org/bugzilla/show_bug.cgi?id=25266

Frank Ch. Eigler <fche at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fche at redhat dot com

--- Comment #1 from Frank Ch. Eigler <fche at redhat dot com> ---
All the runtime autoconf results end up in a stapconf_HEXHEXHEX.h file, did you
see that one?  We can't transcribe dozens of check/results to systemtap's
stderr, that's too chatty.  Maybe with some stap --vp 0x000 level, but then
this level would have to be communicated to the kbuild makefile.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug runtime/25266] Log configure command output when compiling modules

tim@mr-dog.net
In reply to this post by tim@mr-dog.net
https://sourceware.org/bugzilla/show_bug.cgi?id=25266

--- Comment #2 from Craig Ringer <craig.ringer at 2ndquadrant dot com> ---
Yes, it's relatively easy to find the test outcomes, but not why the test
returned success or failure. That's part of why diagnosing these issues took me
so long.

I was thinking it'd make sense to output the configure test results at stap
-vvv or similar. So yes, probably by injecting a variable in the make command
invocation.

--
You are receiving this mail because:
You are the assignee for the bug.