[Bug regex/23744] New: regex refactorings to remove BE, avoid duplication

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug regex/23744] New: regex refactorings to remove BE, avoid duplication

glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=23744

            Bug ID: 23744
           Summary: regex refactorings to remove BE, avoid duplication
           Product: glibc
           Version: 2.28
            Status: NEW
          Severity: minor
          Priority: P2
         Component: regex
          Assignee: unassigned at sourceware dot org
          Reporter: eggert at cs dot ucla.edu
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

Created attachment 11294
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11294&action=edit
Replace BE/__builtin_expect with __glibc_likely and __glibc_unlikely

I'll attach two patches that do not change regex behavior, just make it easier
to maintain. The first replaces uses of the BE macro (short for
__builtin_expect) with the current style __glibc_likely and __glibc_unlikely.
The second avoids code duplication with intprops.h.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug regex/23744] regex refactorings to remove BE, avoid duplication

glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=23744

eggert at cs dot ucla.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |eggert at cs dot ucla.edu

--- Comment #1 from eggert at cs dot ucla.edu ---
Created attachment 11295
  --> https://sourceware.org/bugzilla/attachment.cgi?id=11295&action=edit
simplify by using intprops.h

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug regex/23744] regex refactorings to remove BE, avoid duplication

glaubitz at physik dot fu-berlin.de
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=23744

eggert at cs dot ucla.edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.29

--- Comment #2 from eggert at cs dot ucla.edu ---
I installed the patches and am marking this report as fixed.

--
You are receiving this mail because:
You are on the CC list for the bug.