[Bug nptl/24568] New: gdb colored output makes nptl/test-*-printers fail

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/24568] New: gdb colored output makes nptl/test-*-printers fail

glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=24568

            Bug ID: 24568
           Summary: gdb colored output makes nptl/test-*-printers fail
           Product: glibc
           Version: 2.29
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: nptl
          Assignee: unassigned at sourceware dot org
          Reporter: ats-sourceware at offog dot org
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

With current glibc 2.29 (git 980cb43f15c4320afc6272e7a508f1415413b945) and gdb
8.3, several tests fail:

FAIL: nptl/test-cond-printers
FAIL: nptl/test-condattr-printers
FAIL: nptl/test-mutex-printers
FAIL: nptl/test-mutexattr-printers
FAIL: nptl/test-rwlock-printers
FAIL: nptl/test-rwlockattr-printers

Examining the .out files, this is because gdb is producing messages with color
escapes in them that don't match the patterns the tests expect.

Hacking init_test in test_printers_common.py to do "set style enabled off"
fixes this, but maybe gdb should be in batch mode, or the terminal type set to
something that wouldn't use highlighting instead?

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/24568] gdb colored output makes nptl/test-*-printers fail

Sourceware - glibc-bugs mailing list
https://sourceware.org/bugzilla/show_bug.cgi?id=24568

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
If you set TERM=dumb, gdb won't print these escapes.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/24568] gdb colored output makes nptl/test-*-printers fail

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=24568

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.30

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
I think this was fixed in this commit:

commit 56a731d4ad319e473851893980e734b7ee42c1a0
Author: Jan Kratochvil <[hidden email]>
Date:   Fri Feb 8 13:49:19 2019 -0500

    Avoid readline conflicts in pexpect

    In some cases, sensitive to readline version and the user's
    environment, gdb might emit escape codes while run under python's
    pexpect (i.e. testing pretty printers).  This patch, suggested
    by Jan, helps isolate the test from the user's environment.

    Tested on RHEL 7 x86_64 with DTS 7 and EPEL, which is one
    magic combination of components that triggers this bug.

It went into glibc 2.30.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/24568] gdb colored output makes nptl/test-*-printers fail

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=24568

--- Comment #3 from Adam Sampson <ats-sourceware at offog dot org> ---
I've just tested 2.31 and can confirm the fix works for me - thanks very much!

--
You are receiving this mail because:
You are on the CC list for the bug.