[Bug nptl/17326] New: endless loop in __reclaim_stacks

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/17326] New: endless loop in __reclaim_stacks

glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=17326

            Bug ID: 17326
           Summary: endless loop in __reclaim_stacks
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
          Assignee: unassigned at sourceware dot org
          Reporter: ma.jiang at zte dot com.cn
                CC: drepper.fsp at gmail dot com

Created attachment 7766
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7766&action=edit
my fix for the bug

Hi all,
After the fix mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=477705,
I can still reproduce the bug on a dual-core armv7 board.
As the Linux kernel only guarantee a per-page atomicity when doing fork, just
adding a atomic_write_barrier is not enough to protect the
stack_used/stack_cache lists. We need to stop threads which tried to modify the
lists when a thread is doing fork, only then the child process could get a
coherent list, and the __reclaim_stacks could do the right job.
In fork, we have already done such things for io locks(see _IO_list_lock
(),_IO_list_resetlock () and _IO_list_unlock () in __libc_fork). I belive we
should also add some similar codes to protect the stack_used/stack_cache lists.
I have made a patch(see the attachment),  is that ok for trunk?

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/17326] endless loop in __reclaim_stacks

glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=17326

ma.jiang at zte dot com.cn changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7766|0                           |1
        is obsolete|                            |

--- Comment #1 from ma.jiang at zte dot com.cn ---
Created attachment 7771
  --> https://sourceware.org/bugzilla/attachment.cgi?id=7771&action=edit
fix for trunk

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/17326] endless loop in __reclaim_stacks

glaubitz at physik dot fu-berlin.de
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=17326

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
              Flags|                            |security?

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/17326] endless loop in __reclaim_stacks

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=17326

buque <wuxu.wu at huawei dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wuxu.wu at huawei dot com

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/17326] endless loop in __reclaim_stacks

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=17326

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=26104

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/17326] endless loop in __reclaim_stacks

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=17326

--- Comment #2 from Carlos O'Donell <carlos at redhat dot com> ---
I'm closing this in favour of bug 26104 and contains my analysis. We should
discuss the issue in bug 26104. I don't think that adding additional locking is
the right solution.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug nptl/17326] endless loop in __reclaim_stacks

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=17326

Carlos O'Donell <carlos at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |carlos at redhat dot com

--- Comment #3 from Carlos O'Donell <carlos at redhat dot com> ---
Marking as duplicate of 26104.

*** This bug has been marked as a duplicate of bug 26104 ***

--
You are receiving this mail because:
You are on the CC list for the bug.