[Bug malloc/18465] New: memusagestat is built using system C library

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] New: memusagestat is built using system C library

adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

            Bug ID: 18465
           Summary: memusagestat is built using system C library
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: malloc
          Assignee: unassigned at sourceware dot org
          Reporter: vapier at gentoo dot org
  Target Milestone: ---

the memusagestat binary is not linked against the local copy of glibc.  instead
it relies on whatever is installed.

for example:
$ cd .../glibc
$ export objdir=$PWD/build/x86_64
$ rm $objdir/memusagestat
$ cd malloc
$ make
gcc   -o /usr/local/src/gnu/glibc/build/x86_64/malloc/memusagestat
/usr/local/src/gnu/glibc/build/x86_64/malloc/memusagestat.o  -lgd -lpng -lz -lm

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

Mike Frysinger <vapier at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at sourceware dot org   |vapier at gentoo dot org

--- Comment #1 from Mike Frysinger <vapier at gentoo dot org> ---
https://sourceware.org/ml/libc-alpha/2015-05/msg00871.html

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fweimer at redhat dot com
           Assignee|vapier at gentoo dot org           |fweimer at redhat dot com

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Florian Weimer <[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=f9b645b4b0a10c43753296ce3fa40053fa44606a

commit f9b645b4b0a10c43753296ce3fa40053fa44606a
Author: Mike Frysinger <[hidden email]>
Date:   Wed Apr 24 13:32:22 2019 +0200

    memusagestat: use local glibc when linking [BZ #18465]

    The memusagestat is the only binary that has its own link line which
    causes it to be linked against the existing installed C library.  It
    has been this way since it was originally committed in 1999, but I
    don't see any reason as to why.  Since we want all the programs we
    build locally to be against the new copy of glibc, change the build
    to be like all other programs.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.30

--- Comment #3 from Florian Weimer <fweimer at redhat dot com> ---
Fixed for glibc 2.30.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugzilla.redhat.com
                   |                            |/show_bug.cgi?id=1702671

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.29/master branch has been updated by Florian Weimer
<[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=42dfc13abf6fbb4c7a0215238eb636b7d374e0e0

commit 42dfc13abf6fbb4c7a0215238eb636b7d374e0e0
Author: Mike Frysinger <[hidden email]>
Date:   Wed Apr 24 19:07:46 2019 +0200

    memusagestat: use local glibc when linking [BZ #18465]

    The memusagestat is the only binary that has its own link line which
    causes it to be linked against the existing installed C library.  It
    has been this way since it was originally committed in 1999, but I
    don't see any reason as to why.  Since we want all the programs we
    build locally to be against the new copy of glibc, change the build
    to be like all other programs.

    (cherry picked from commit f9b645b4b0a10c43753296ce3fa40053fa44606a)

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.28/master branch has been updated by Florian Weimer
<[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=630d7201ceb12f8dcdbe20abce67e1333c5e15ee

commit 630d7201ceb12f8dcdbe20abce67e1333c5e15ee
Author: Mike Frysinger <[hidden email]>
Date:   Wed Apr 24 19:30:53 2019 +0200

    memusagestat: use local glibc when linking [BZ #18465]

    The memusagestat is the only binary that has its own link line which
    causes it to be linked against the existing installed C library.  It
    has been this way since it was originally committed in 1999, but I
    don't see any reason as to why.  Since we want all the programs we
    build locally to be against the new copy of glibc, change the build
    to be like all other programs.

    (cherry picked from commit f9b645b4b0a10c43753296ce3fa40053fa44606a)

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Florian Weimer <[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a8ff215e56050a907189e713fd449bcafe99ff6b

commit a8ff215e56050a907189e713fd449bcafe99ff6b
Author: Florian Weimer <[hidden email]>
Date:   Fri Apr 26 07:16:30 2019 +0200

    Makeconfig: Move -Wl,-rpath-link options before library references

    Previously, the -Wl,-rpath-link options came after the libraries
    injected using LDLIBS-* variables on the link editor command line for
    main programs.  As a result, it could happen that installed libraries
    that reference glibc libraries used the installed glibc from the system
    directories, instead of the glibc from the build tree.  This can lead to
    link failures if the wrong version of libpthread.so.0 is used, for
    instance, due to differences in the internal GLIBC_PRIVATE interfaces,
    as seen with memusagestat and -lgd after commit
    f9b645b4b0a10c43753296ce3fa40053fa44606a ("memusagestat: use local glibc
    when linking [BZ #18465]").

    The isolation is necessarily imperfect because these installed
    libraries are linked against the installed glibc in the system
    directories.  However, in most cases, the built glibc will be newer
    than the installed glibc, and this link is permitted because of the
    ABI backwards compatibility glibc provides.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

--- Comment #7 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.29/master branch has been updated by Florian Weimer
<[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0744a268bc73e42b14b83e4cf3d083c6df6344e8

commit 0744a268bc73e42b14b83e4cf3d083c6df6344e8
Author: Florian Weimer <[hidden email]>
Date:   Thu Apr 25 14:58:13 2019 +0200

    Revert "memusagestat: use local glibc when linking [BZ #18465]"

    This reverts commit 42dfc13abf6fbb4c7a0215238eb636b7d374e0e0.

    The position of the -Wl,-rpath-link= options on the linker command
    line is not correct, so the new way of linking memusagestat does not
    always work.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug malloc/18465] memusagestat is built using system C library

adhemerval.zanella at linaro dot org
In reply to this post by adhemerval.zanella at linaro dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=18465

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The release/2.28/master branch has been updated by Florian Weimer
<[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=9b3aac586964f7aee071aa25fef86d53b05d16b2

commit 9b3aac586964f7aee071aa25fef86d53b05d16b2
Author: Florian Weimer <[hidden email]>
Date:   Thu Apr 25 14:59:42 2019 +0200

    Revert "memusagestat: use local glibc when linking [BZ #18465]"

    This reverts commit 630d7201ceb12f8dcdbe20abce67e1333c5e15ee.

    The position of the -Wl,-rpath-link= options on the linker command
    line is not correct, so the new way of linking memusagestat does not
    always work.

--
You are receiving this mail because:
You are on the CC list for the bug.