[Bug linuxthreads/3248] New: unportable sigprocmask() in gai_misc.h

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] New: unportable sigprocmask() in gai_misc.h

tim@mr-dog.net
Hi,

please, could in just added gai_misc.h use __sigprocmask instead
of direct using Linux syscalls ? For linuxthreads add-on on  Linux it is equal,
but on GNU/kFreeBSD  syscall rt_sigprocmask really does not exist.

Many thanks

    Petr

2006-09-22  Petr Salinger  <Petr.Salinger@seznam..cz>

        * sysdeps/pthread/gai_misc.h: use __sigprocmask()

--
           Summary: unportable sigprocmask() in gai_misc.h
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: linuxthreads
        AssignedTo: drow at false dot org
        ReportedBy: Petr dot Salinger at seznam dot cz
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] unportable sigprocmask() in gai_misc.h

tim@mr-dog.net

------- Additional Comments From Petr dot Salinger at seznam dot cz  2006-09-22 19:47 -------
Created an attachment (id=1317)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1317&action=view)
proposed patch


--


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] unportable sigprocmask() in gai_misc.h

tim@mr-dog.net
In reply to this post by tim@mr-dog.net

------- Additional Comments From drow at sources dot redhat dot com  2006-10-01 04:06 -------
Sure; I've checked that in, with minor formatting fixes.  Thanks for the patch.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
            Summary|unportable sigprocmask() in |unportable sigprocmask() in
                   |gai_misc.h                  |gai_misc.h


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] unportable sigprocmask() in gai_misc.h

tim@mr-dog.net
In reply to this post by tim@mr-dog.net

------- Additional Comments From drow at sources dot redhat dot com  2006-10-02 18:24 -------
Petr, had you tested that patch?  I didn't - egg on my face.  It breaks the build.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] unportable sigprocmask() in gai_misc.h

tim@mr-dog.net
In reply to this post by tim@mr-dog.net

------- Additional Comments From drow at sources dot redhat dot com  2006-10-02 18:42 -------
I've fixed it.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] unportable sigprocmask() in gai_misc.h

tim@mr-dog.net
In reply to this post by tim@mr-dog.net

------- Additional Comments From Petr dot Salinger at seznam dot cz  2006-10-02 19:31 -------
(In reply to comment #3)

> Petr, had you tested that patch?  I didn't - egg on my face.
>  It breaks the build.

Yes, for kfreebsd-i386.
It have worked fine and testsuite have passsed reasonably.
Test have been against snapshot from 2006-09-18, with gai_misc.h added.

May be make didn't catch all changes correctly (I have tested iteratively also
changes to our sysdeps for upcoming glibc 2.5) or it works for  kfreebsd but not
for Linux .

Sorry for the problem and many thanks for fixing it again.

Petr


--


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] unportable sigprocmask() in gai_misc.h

tim@mr-dog.net
In reply to this post by tim@mr-dog.net

------- Additional Comments From drow at false dot org  2006-10-02 19:35 -------
Subject: Re:  unportable sigprocmask() in gai_misc.h

On Mon, Oct 02, 2006 at 07:31:40PM -0000, Petr dot Salinger at seznam dot cz wrote:
> May be make didn't catch all changes correctly (I have tested iteratively also
> changes to our sysdeps for upcoming glibc 2.5) or it works for  kfreebsd but not
> for Linux .

Do you not have symbol versioning on that platform?  __sigprocmask is
not exported from libc.so nor normally present in libpthread.so.



--


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug linuxthreads/3248] unportable sigprocmask() in gai_misc.h

tim@mr-dog.net
In reply to this post by tim@mr-dog.net

------- Additional Comments From Petr dot Salinger at seznam dot cz  2006-10-02 20:47 -------
> Do you not have symbol versioning on that platform?  

We have symbol versioning.

> __sigprocmask is not exported from libc.so nor normally present in libpthread.so.

You got it.

We export  __sigprocmask in version GLIBC_PRIVATE as  __sigprocmask is used
internally in libpthread during emulation of clone syscall.
So our libc.so exports it, but Linux's don't.

Again sorry for the problem.

Petr


--


http://sourceware.org/bugzilla/show_bug.cgi?id=3248

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.