[Bug libc/2611] New: bug/typo in stdio-common/renameat.c

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug libc/2611] New: bug/typo in stdio-common/renameat.c

fweimer at redhat dot com
Hi,

there is a typo in stdio-common/renameat.c,
"&&" should be used instead of "&".

Petr


--- stdio-common/renameat.c~     2006-04-27 10:19:47.000000000 +0200
+++ stdio-common/renameat.c      2006-04-27 10:19:47.000000000 +0200
@@ -29,7 +29,7 @@
      int newfd;
      const char *new;
 {
-  if ((oldfd < 0 & oldfd != AT_FDCWD) || (newfd < 0 && newfd != AT_FDCWD))
+  if ((oldfd < 0 && oldfd != AT_FDCWD) || (newfd < 0 && newfd != AT_FDCWD))
     {
       __set_errno (EBADF);
       return -1;

--
           Summary: bug/typo in stdio-common/renameat.c
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: Petr dot Salinger at seznam dot cz
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2611

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/2611] bug/typo in stdio-common/renameat.c

fweimer at redhat dot com

------- Additional Comments From drepper at redhat dot com  2006-04-27 14:31 -------
The file is not used at all but should nevertheless be correct.  Applied.

--
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=2611

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
Reply | Threaded
Open this post in threaded view
|

Re: [Bug libc/2611] bug/typo in stdio-common/renameat.c

Thomas Schwinge-6
On Thu, Apr 27, 2006 at 02:31:05PM -0000, drepper at redhat dot com wrote:
> > [stdio-common/renameat.c]
>
> The file is not used at all but should nevertheless be correct.  Applied.

Eh?  Sure that file is being used.  Nevertheless, thanks for fixing this.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/2611] bug/typo in stdio-common/renameat.c

fweimer at redhat dot com
In reply to this post by fweimer at redhat dot com

------- Additional Comments From tschwinge at gnu dot org  2006-04-27 21:50 -------
Subject: Re:  bug/typo in stdio-common/renameat.c

On Thu, Apr 27, 2006 at 02:31:05PM -0000, drepper at redhat dot com wrote:
> > [stdio-common/renameat.c]
>
> The file is not used at all but should nevertheless be correct.  Applied.

Eh?  Sure that file is being used.  Nevertheless, thanks for fixing this.


--


http://sourceware.org/bugzilla/show_bug.cgi?id=2611

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.