[Bug libc/24794] New: Partial test suite run builds corrupt test-in-container testroot

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] New: Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

            Bug ID: 24794
           Summary: Partial test suite run builds corrupt
                    test-in-container testroot
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---
             Flags: security-

Running

$ make subdirs=libio check

or:

$ make libio/tests

results in a corrupt testroot because not all the required contents is
installed (iconvconfig is missing, for instance).  This results in false test
failures.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

--- Comment #1 from Florian Weimer <fweimer at redhat dot com> ---
To reproduce this, it's necessary to build glibc first, before running these
commands, i.e. invoke “make”, “make -j8” or something like that.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
In reply to this post by fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tuliom at ascii dot art.br

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
In reply to this post by fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tulio Magno Quites Machado Filho
<[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=35e038c1d2ccb3a75395662f9c4f28d85a61444f

commit 35e038c1d2ccb3a75395662f9c4f28d85a61444f
Author: Tulio Magno Quites Machado Filho <[hidden email]>
Date:   Mon Jul 22 17:34:13 2019 -0300

    test-container: Install with $(all-subdirs) [BZ #24794]

    Whenever a sub-make is created, it inherits the variable subdirs from its
    parent.  This is also true when make check is called with a restricted
    list of subdirs.  In this scenario, make install is executed "partially"
    and testroot.pristine ends up with an incomplete installation.

        [BZ #24794]
        * Makefile (testroot.pristine/install.stamp): Pass
        subdirs='$(all-subdirs)' to make install.

    Reviewed-by: DJ Delorie <[hidden email]>

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
In reply to this post by fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at sourceware dot org   |tuliom at ascii dot art.br
   Target Milestone|---                         |2.30

--- Comment #3 from Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> ---
Fixed in glibc 2.30.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
In reply to this post by fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

Romain Geissler <romain.geissler at amadeus dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |romain.geissler at amadeus dot com

--- Comment #4 from Romain Geissler <romain.geissler at amadeus dot com> ---
Hi,

This commit caused two regressions for me:

    FAIL: elf/tst-ldconfig-bad-aux-cache
    FAIL: nss/tst-nss-files-hosts-long

I haven't tried the patch from
https://sourceware.org/ml/libc-alpha/2019-07/msg00564.html yet.

Cheers,
Romain

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
In reply to this post by fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tulio Magno Quites Machado Filho
<[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=354e4c1adddb1da19c1043e3e5db61ee2148d912

commit 354e4c1adddb1da19c1043e3e5db61ee2148d912
Author: Tulio Magno Quites Machado Filho <[hidden email]>
Date:   Wed Jul 24 19:49:00 2019 -0300

    test-container: Install with $(sorted-subdirs) [BZ #24794]

    Commit 35e038c1d2ccb3a75395662f9c4f28d85a61444f started to use an
    incomplete list of subdirs based on $(all-subdirs) causing
    testroot.pristine to miss files from nss.

    Tested if the list of files in testroot.pristine remains the same.

        [BZ #24794]
        * Makeconfig (all-subdirs): Improved source comments.
        * Makefile (testroot.pristine/install.stamp): Pass
        subdirs='$(sorted-subdirs)' to make install.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug libc/24794] Partial test suite run builds corrupt test-in-container testroot

fche at redhat dot com
In reply to this post by fche at redhat dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24794

--- Comment #6 from Tulio Magno Quites Machado Filho <tuliom at ascii dot art.br> ---
(In reply to Romain Geissler from comment #4)
> This commit caused two regressions for me:
>
>     FAIL: elf/tst-ldconfig-bad-aux-cache
>     FAIL: nss/tst-nss-files-hosts-long
>
> I haven't tried the patch from
> https://sourceware.org/ml/libc-alpha/2019-07/msg00564.html yet.

Romain,

Commit 354e4c1adddb1 should fix these regressions.

--
You are receiving this mail because:
You are on the CC list for the bug.