[Bug libc/22489] New: gcc warns about implicit convertion in ICMP6_FILTER_SETPASS with -Wsign-conversion

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug libc/22489] New: gcc warns about implicit convertion in ICMP6_FILTER_SETPASS with -Wsign-conversion

glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=22489

            Bug ID: 22489
           Summary: gcc warns about implicit convertion in
                    ICMP6_FILTER_SETPASS with -Wsign-conversion
           Product: glibc
           Version: 2.26
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: s.korolev at ndmsystems dot com
                CC: drepper.fsp at gmail dot com
  Target Milestone: ---

Created attachment 10633
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10633&action=edit
A patch to fix

The simplest code (icmp6_test.c)

#include <stdlib.h>                                                          
#include <netinet/icmp6.h>                                                    

int main()                                                                    
{                                                                            
    struct icmp6_filter filter;                                              

    ICMP6_FILTER_SETPASS(ND_ROUTER_ADVERT, &filter);                          

    return EXIT_SUCCESS;                                                      
}

compiled with "gcc icmp6_test.c -Wsign-conversion" gives a warning

icmp6_test.c: In function ‘main’:
icmp6_test.c:8:2: warning: negative integer implicitly converted to unsigned
type [-Wsign-conversion]
  ICMP6_FILTER_SETPASS(ND_ROUTER_ADVERT, &filter);

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug network/22489] gcc warns about implicit convertion in ICMP6_FILTER_SETPASS with -Wsign-conversion

glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=22489

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libc                        |network

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug network/22489] gcc warns about implicit convertion in ICMP6_FILTER_SETPASS with -Wsign-conversion

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=22489

Roy Marples <roy at marples dot name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roy at marples dot name

--- Comment #1 from Roy Marples <roy at marples dot name> ---
Can this be progressed please?

Compiling dhcpcd with debugging flags always throws this up and it's highly
annoying. I can confirm this patch removes the warning generated.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug network/22489] gcc warns about implicit convertion in ICMP6_FILTER_SETPASS with -Wsign-conversion

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=22489

dj at redhat dot com <dj at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |dj at redhat dot com

--- Comment #2 from dj at redhat dot com <dj at redhat dot com> ---
Fixed in upstream c2d0411488c68a07cc22a5dd76fa37e952d2a66b

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug network/22489] gcc warns about implicit convertion in ICMP6_FILTER_SETPASS with -Wsign-conversion

Sourceware - glibc-bugs mailing list
In reply to this post by glaubitz at physik dot fu-berlin.de
https://sourceware.org/bugzilla/show_bug.cgi?id=22489

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.32

--
You are receiving this mail because:
You are on the CC list for the bug.