[Bug dynamic-link/20890] New: ldconfig: fsync the files before atomic rename

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug dynamic-link/20890] New: ldconfig: fsync the files before atomic rename

tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=20890

            Bug ID: 20890
           Summary: ldconfig: fsync the files before atomic rename
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dynamic-link
          Assignee: unassigned at sourceware dot org
          Reporter: fweimer at redhat dot com
  Target Milestone: ---
             Flags: security-

ldconfig does not fsync the temporary files for the caches before renaming them
into the final place.  As a result, a crash at an inopportune moment can leave
corrupted crashes behind.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug dynamic-link/20890] ldconfig: fsync the files before atomic rename

tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=20890

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://sourceware.org/bugz
                   |                            |illa/show_bug.cgi?id=18093

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug dynamic-link/20890] ldconfig: fsync the files before atomic rename

tromey at sourceware dot org
In reply to this post by tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=20890

github at kalvdans dot no-ip.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |github at kalvdans dot no-ip.org

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug dynamic-link/20890] ldconfig: fsync the files before atomic rename

tromey at sourceware dot org
In reply to this post by tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=20890

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at sourceware dot org   |fweimer at redhat dot com

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug dynamic-link/20890] ldconfig: fsync the files before atomic rename

tromey at sourceware dot org
In reply to this post by tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=20890

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  999a6dab3ee1c8e77bb348ba2389e7aeb5c062b2 (commit)
      from  52a01100ad011293197637e42b5be1a479a2f4ae (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=999a6dab3ee1c8e77bb348ba2389e7aeb5c062b2

commit 999a6dab3ee1c8e77bb348ba2389e7aeb5c062b2
Author: Florian Weimer <[hidden email]>
Date:   Wed Feb 21 10:42:48 2018 +0100

    ldconfig: Sync temporary files to disk before renaming them [BZ #20890]

    If the system crashes before the file data has been written to disk, the
    file system recovery upon the next mount may restore a partially
    rewritten temporary file under the non-temporary (final) name (after the
    rename operation).

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog   |    8 ++++++++
 elf/cache.c |   10 +++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug dynamic-link/20890] ldconfig: fsync the files before atomic rename

tromey at sourceware dot org
In reply to this post by tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=20890

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.28

--- Comment #2 from Florian Weimer <fweimer at redhat dot com> ---
Fixed in 2.28.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug dynamic-link/20890] ldconfig: fsync the files before atomic rename

tromey at sourceware dot org
In reply to this post by tromey at sourceware dot org
https://sourceware.org/bugzilla/show_bug.cgi?id=20890

Jeremi <jeremip11 at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jeremip11 at gmail dot com

--
You are receiving this mail because:
You are on the CC list for the bug.