[Bug cli/24732] New: completion does not work properly in pipe command

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug cli/24732] New: completion does not work properly in pipe command

Martin.Jansa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24732

            Bug ID: 24732
           Summary: completion does not work properly in pipe command
           Product: gdb
           Version: unknown
            Status: NEW
          Severity: normal
          Priority: P2
         Component: cli
          Assignee: unassigned at sourceware dot org
          Reporter: tromey at sourceware dot org
  Target Milestone: ---

Completion doesn't work properly in the pipe command.

Try

(gdb) | maint print psym<TAB>

For me this does nothing.  Removing the "|" and trying ordinary
completion gives:

(gdb) maint print psymbols

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug cli/24732] completion does not work properly in pipe command

Martin.Jansa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24732

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.waroquiers@skynet.
                   |                            |be

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug cli/24732] completion does not work properly in pipe command

Martin.Jansa at gmail dot com
In reply to this post by Martin.Jansa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24732

--- Comment #1 from philippe.waroquiers at skynet dot be ---
Effectively, pipe command has no completer.
I will add one.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug cli/24732] completion does not work properly in pipe command

Martin.Jansa at gmail dot com
In reply to this post by Martin.Jansa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24732

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5f4ba3e701d74f280d4bd8820d9c39a854e0d2cf

commit 5f4ba3e701d74f280d4bd8820d9c39a854e0d2cf
Author: Pedro Alves <[hidden email]>
Date:   Wed Jul 3 16:57:51 2019 +0100

    pipe command completer

    This commit adds a completer for the "pipe" command.  It can complete
    "pipe"'s options, and the specified GDB command.

    To make the completer aware of the "-d" option, this converts the
    option processing to use gdb::option.

    Tests included.

    gdb/ChangeLog:
    2019-07-03  Pedro Alves  <[hidden email]>

        PR cli/24732
        * cli/cli-cmds.c (struct pipe_cmd_opts): New.
        (pipe_cmd_option_defs): New.
        (make_pipe_cmd_options_def_group): New.
        (pipe_command): Use gdb::option::process_options.
        (pipe_command_completer): New function.
        (_initialize_cli_cmds): Install completer for "pipe" command.

    gdb/testsuite/ChangeLog:
    2019-07-03  Pedro Alves  <[hidden email]>

        PR cli/24732
        * gdb.base/shell.exp: Load completion-support.exp.
        Adjust expected error output.  Add completion tests.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug cli/24732] completion does not work properly in pipe command

Martin.Jansa at gmail dot com
In reply to this post by Martin.Jansa at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24732

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |9.1

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

--
You are receiving this mail because:
You are on the CC list for the bug.