[Bug build/23053] New: Fix -D_GLIBCXX_DEBUG gdb-add-index regression

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug build/23053] New: Fix -D_GLIBCXX_DEBUG gdb-add-index regression

rootedjoy833 at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23053

            Bug ID: 23053
           Summary: Fix -D_GLIBCXX_DEBUG gdb-add-index regression
           Product: gdb
           Version: 8.1
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: jan.kratochvil at redhat dot com
  Target Milestone: ---

[patch+8.1] Fix -D_GLIBCXX_DEBUG gdb-add-index regression
https://sourceware.org/ml/gdb-patches/2018-02/msg00057.html
Message-ID: <[hidden email]>

PASS: gdb-8.0
FAIL: gdb-8.1

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug build/23053] Fix -D_GLIBCXX_DEBUG gdb-add-index regression

rootedjoy833 at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23053

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.kratochvil at redhat dot com
           Assignee|unassigned at sourceware dot org   |jan.kratochvil at redhat dot com
   Target Milestone|---                         |8.1.1

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug gdb/23053] Fix -D_GLIBCXX_DEBUG gdb-add-index regression

rootedjoy833 at gmail dot com
In reply to this post by rootedjoy833 at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23053

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|build                       |gdb

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug gdb/23053] Fix -D_GLIBCXX_DEBUG gdb-add-index regression

rootedjoy833 at gmail dot com
In reply to this post by rootedjoy833 at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23053

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Kratochvil <[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b4be9bfdabb57f40656e72a50a8466af4f7bd37d

commit b4be9bfdabb57f40656e72a50a8466af4f7bd37d
Author: Jan Kratochvil <[hidden email]>
Date:   Thu Apr 12 22:31:39 2018 +0200

    Fix -D_GLIBCXX_DEBUG gdb-add-index regression

    Fedora Rawhide started to use -D_GLIBCXX_DEBUG which made gdb-add-index
    failing:
        gdb: Out-of-bounds vector access while running gdb-add-index
        https://bugzilla.redhat.com/show_bug.cgi?id=1540559

    /usr/include/c++/7/debug/safe_iterator.h:270:
    Error: attempt to dereference a past-the-end iterator.
    Objects involved in the operation:
        iterator "this" @ 0x0x7fffffffcb90 {
          type =
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<unsigned char*,
std::__cxx1998::vector<unsigned char, gdb::default_init_allocator<unsigned
char, std::allocator<unsigned char> > > >, std::__debug::vector<unsigned char,
gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > >
(mutable iterator);
          state = past-the-end;
          references sequence with type 'std::__debug::vector<unsigned char,
gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > >' @
0x0x7fffffffcc50
        }

    /usr/include/c++/7/debug/vector:417:
    Error: attempt to subscript container with out-of-bounds index 556, but
    container only holds 556 elements.
    Objects involved in the operation:
        sequence "this" @ 0x0x2e87af8 {
          type = std::__debug::vector<partial_symbol*,
std::allocator<partial_symbol*> >;
        }

    The two -D_GLIBCXX_DEBUG regressions were made by:

    commit bc8f2430e08cc2a520db49a42686e0529be4a3bc
    Author: Jan Kratochvil <[hidden email]>
    Date:   Mon Jun 12 16:29:53 2017 +0100
        Code cleanup: C++ify .gdb_index producer

    commit af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319
    Author: Simon Marchi <[hidden email]>
    Date:   Sat Oct 14 08:06:29 2017 -0400
        Replace psymbol_allocation_list with std::vector

    gdb/ChangeLog
    2018-04-12  Jan Kratochvil  <[hidden email]>

        PR gdb/23053
        * dwarf-index-write.c (data_buf::grow) (write_one_signatured_type)
        (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
        (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
        regression.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug gdb/23053] Fix -D_GLIBCXX_DEBUG gdb-add-index regression

rootedjoy833 at gmail dot com
In reply to this post by rootedjoy833 at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23053

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-8.1-branch branch has been updated by Jan Kratochvil
<[hidden email]>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=55404da3795df1b5eff514ce9d0377b6a78e5904

commit 55404da3795df1b5eff514ce9d0377b6a78e5904
Author: Jan Kratochvil <[hidden email]>
Date:   Thu Apr 12 22:31:39 2018 +0200

    Fix -D_GLIBCXX_DEBUG gdb-add-index regression

    Fedora Rawhide started to use -D_GLIBCXX_DEBUG which made gdb-add-index
    failing:
        gdb: Out-of-bounds vector access while running gdb-add-index
        https://bugzilla.redhat.com/show_bug.cgi?id=1540559

    /usr/include/c++/7/debug/safe_iterator.h:270:
    Error: attempt to dereference a past-the-end iterator.
    Objects involved in the operation:
        iterator "this" @ 0x0x7fffffffcb90 {
          type =
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<unsigned char*,
std::__cxx1998::vector<unsigned char, gdb::default_init_allocator<unsigned
char, std::allocator<unsigned char> > > >, std::__debug::vector<unsigned char,
gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > > >
(mutable iterator);
          state = past-the-end;
          references sequence with type 'std::__debug::vector<unsigned char,
gdb::default_init_allocator<unsigned char, std::allocator<unsigned char> > >' @
0x0x7fffffffcc50
        }

    /usr/include/c++/7/debug/vector:417:
    Error: attempt to subscript container with out-of-bounds index 556, but
    container only holds 556 elements.
    Objects involved in the operation:
        sequence "this" @ 0x0x2e87af8 {
          type = std::__debug::vector<partial_symbol*,
std::allocator<partial_symbol*> >;
        }

    The two -D_GLIBCXX_DEBUG regressions were made by:

    commit bc8f2430e08cc2a520db49a42686e0529be4a3bc
    Author: Jan Kratochvil <[hidden email]>
    Date:   Mon Jun 12 16:29:53 2017 +0100
        Code cleanup: C++ify .gdb_index producer

    commit af5bf4ada48ff65b6658be1fab8f9c8f8ab5f319
    Author: Simon Marchi <[hidden email]>
    Date:   Sat Oct 14 08:06:29 2017 -0400
        Replace psymbol_allocation_list with std::vector

    gdb/ChangeLog
    2018-04-12  Jan Kratochvil  <[hidden email]>

        PR gdb/23053
        * dwarf2read.c (data_buf::grow) (write_one_signatured_type)
        (recursively_write_psymbols) (debug_names::recursively_write_psymbols)
        (debug_names::write_one_signatured_type): Fix -D_GLIBCXX_DEBUG
        regression.

--
You are receiving this mail because:
You are on the CC list for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug gdb/23053] Fix -D_GLIBCXX_DEBUG gdb-add-index regression

rootedjoy833 at gmail dot com
In reply to this post by rootedjoy833 at gmail dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=23053

Jan Kratochvil <jan.kratochvil at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jan Kratochvil <jan.kratochvil at redhat dot com> ---
Fixed.

--
You are receiving this mail because:
You are on the CC list for the bug.