[Bug bpf/24543] New: stapbpf breaks when cpu0 is disabled

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug bpf/24543] New: stapbpf breaks when cpu0 is disabled

986882896 at qq dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24543

            Bug ID: 24543
           Summary: stapbpf breaks when cpu0 is disabled
           Product: systemtap
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: bpf
          Assignee: systemtap at sourceware dot org
          Reporter: me at serhei dot io
  Target Milestone: ---

There is code in stapbpf to handle the case when some cpu cores are disabled.

However, certain things in stapbpf.cxx are still hardcoded to cpu0 (e.g. perf
group fd). If cpu0 is disabled, stapbpf doesn't work.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[Bug bpf/24543] stapbpf breaks when cpu0 is disabled

986882896 at qq dot com
https://sourceware.org/bugzilla/show_bug.cgi?id=24543

Serhei Makarov <me at serhei dot io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Serhei Makarov <me at serhei dot io> ---
Strictly speaking cpu0 is not always safe or possible to disable. But I was
able to do so on a test vm, so the fix has been committed just in case. (As
usual, before the fix stapbpf's error message is based on a failing syscall
return code, which fails to reveal the reason why things don't work.)

--
You are receiving this mail because:
You are the assignee for the bug.