2.30 branch created, snapshot available

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

2.30 branch created, snapshot available

Nick Clifton
Hi Guys,

  The 2.30 branch has now been created:

     git clone git://sourceware.org/git/binutils-gdb.git -b binutils-2_30-branch 2.30

  A snapshot of the sources is also available here:

    ftp://sourceware.org/pub/binutils/snapshots/binutils-2.30.tar.xz

  Please could all patches for the branch be run by me.
  The rules for the branch are:

    * No new features.
    * Target specific bug fixes are OK.
    * Generic bug fixes are OK if they are important and widely tested.
    * Documentation updates/fixes are OK.
    * Translation updates are OK.
    * Fixes for testsuite failures are OK.

  Ideally I would like to make the release happen in two weeks time,
  ie Saturday 27th Jan.  Which I hope will be enough time for everyone
  to get their final fixes in.

Cheers
  Nick
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Joel Brobecker
>   The 2.30 branch has now been created:
>
>      git clone git://sourceware.org/git/binutils-gdb.git -b binutils-2_30-branch 2.30

And I have updated the crontab on sourceware.org to update
the date of this branch instead of the previous one.

--
Joel
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Matt Rice-2
In reply to this post by Nick Clifton
On Sat, Jan 13, 2018 at 6:27 AM, Nick Clifton <[hidden email]> wrote:
>   A snapshot of the sources is also available here:
>
>     ftp://sourceware.org/pub/binutils/snapshots/binutils-2.30.tar.xz

I wanted to confirm that i built the snapshot on a yacc less machine
with --enable-gold,
so the release process changes from shortly after last release took.

https://sourceware.org/ml/binutils/2017-09/msg00137.html
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Nick Clifton
In reply to this post by Joel Brobecker
Hi Joel,

>>   The 2.30 branch has now been created:
>>
>>      git clone git://sourceware.org/git/binutils-gdb.git -b binutils-2_30-branch 2.30
>
> And I have updated the crontab on sourceware.org to update
> the date of this branch instead of the previous one.

Thanks.

Is this something an ordinary person can do ?  If so, would you
mind updating the binutils/README-how-to-make-a-release file with
the details of what needs to be done ?  Or alternatively please
could you add a note along the lines of "ping Joel to ask him
to update the crontab" ?

Cheers
  Nick
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Joel Brobecker
> Is this something an ordinary person can do ?  If so, would you
> mind updating the binutils/README-how-to-make-a-release file with
> the details of what needs to be done ?  Or alternatively please
> could you add a note along the lines of "ping Joel to ask him
> to update the crontab" ?

It requires access to the gdbadmin account on sourceware. Not very
many people do, and if you are going to rotate the role of release
manager, it may not be worth adding everyone. I don't mind doing it,
so attached is a patch which adds an action item describing what
needs to be done, and who to contact to get it done when not in
the gdbadmin group.

binutils/ChangeLog:

        * README-how-to-make-a-release: Add reminder to update the
        branch name in gdbadmin's crontab on sourceware.

OK to push to master?

--
Joel

0001-binutils-release-procedure-Add-AI-to-update-branch-n.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Nick Clifton
Hi Joel,

> binutils/ChangeLog:
>
>         * README-how-to-make-a-release: Add reminder to update the
>         branch name in gdbadmin's crontab on sourceware.
>
> OK to push to master?

Yes please.  Thanks very much for doing this.

Cheers
  Nick


Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Joel Brobecker
> > binutils/ChangeLog:
> >
> >         * README-how-to-make-a-release: Add reminder to update the
> >         branch name in gdbadmin's crontab on sourceware.
> >
> > OK to push to master?
>
> Yes please.  Thanks very much for doing this.

My pleasure :). Pushed to master.

--
Joel
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Matthias Klose-6
In reply to this post by Joel Brobecker
On 15.01.2018 08:29, Joel Brobecker wrote:
>>   The 2.30 branch has now been created:
>>
>>      git clone git://sourceware.org/git/binutils-gdb.git -b binutils-2_30-branch 2.30
>
> And I have updated the crontab on sourceware.org to update
> the date of this branch instead of the previous one.

The version number on the branch seems to be incorrect. It's now
2.30.0.20180123, pointing to a version after the initial 2.30 release (unless
you plan to call the first 2.30 release 2.30.1).

The version number should be 2.29.90.20180123, just bumping 2.29.51 to 2.29.90
in bfd/version.m4 before the first release.

Matthias
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Joel Brobecker
> The version number on the branch seems to be incorrect. It's now
> 2.30.0.20180123, pointing to a version after the initial 2.30 release
> (unless you plan to call the first 2.30 release 2.30.1).
>
> The version number should be 2.29.90.20180123, just bumping 2.29.51 to
> 2.29.90 in bfd/version.m4 before the first release.

Mathias is correct. The version number comes from an explicit change:

    commit 02e0d43c0451f74830b44c78e6045e93f17921e6
    Date:   Sat Jan 13 14:03:53 2018 +0000
    Subject: Reset version number to 2.30.0

There's only been a handfull of days since the branch was created,
and until further notice days always increase ;-), so I don't think
it would be a problem to change it to 2.29.90...

--
Joel
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Nick Clifton
Hi Guys,

>> The version number on the branch seems to be incorrect. It's now
>> 2.30.0.20180123, pointing to a version after the initial 2.30 release
>> (unless you plan to call the first 2.30 release 2.30.1).

*sigh*  A case of premature version incrementing...

I have reset the version to 2.29.90.

Cheers
  Nick
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Joseph Myers
On Tue, 23 Jan 2018, Nick Clifton wrote:

> Hi Guys,
>
> >> The version number on the branch seems to be incorrect. It's now
> >> 2.30.0.20180123, pointing to a version after the initial 2.30 release
> >> (unless you plan to call the first 2.30 release 2.30.1).
>
> *sigh*  A case of premature version incrementing...
>
> I have reset the version to 2.29.90.

I'm now seeing a build failure from my glibc bots using 2.30 branch:

In file included from /scratch/jmyers/glibc-bot/src/binutils/gprof/gprof.h:41:0,
                 from /scratch/jmyers/glibc-bot/src/binutils/gprof/basic_blocks.c:24:
./gconfig.h:101:0: error: "VERSION" redefined [-Werror]
 #define VERSION "2.30.0"
 ^
In file included from /scratch/jmyers/glibc-bot/src/binutils/gprof/../bfd/sysdep.h:29:0,
                 from /scratch/jmyers/glibc-bot/src/binutils/gprof/gprof.h:33,
                 from /scratch/jmyers/glibc-bot/src/binutils/gprof/basic_blocks.c:24:
../bfd/config.h:385:0: note: this is the location of the previous definition
 #define VERSION "2.29.90"
 ^
cc1: all warnings being treated as errors
Makefile:513: recipe for target 'basic_blocks.o' failed
make[5]: *** [basic_blocks.o] Error 1


--
Joseph S. Myers
[hidden email]
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Franz Sirl
In reply to this post by Nick Clifton
Am 2018-01-13 um 15:27 schrieb Nick Clifton:

> Hi Guys,
>
>    The 2.30 branch has now been created:
>
>       git clone git://sourceware.org/git/binutils-gdb.git -b binutils-2_30-branch 2.30
>
>    A snapshot of the sources is also available here:
>
>      ftp://sourceware.org/pub/binutils/snapshots/binutils-2.30.tar.xz
>
>    Please could all patches for the branch be run by me.
>    The rules for the branch are:
>
>      * No new features.
>      * Target specific bug fixes are OK.
>      * Generic bug fixes are OK if they are important and widely tested.
>      * Documentation updates/fixes are OK.
>      * Translation updates are OK.
>      * Fixes for testsuite failures are OK.
>
>    Ideally I would like to make the release happen in two weeks time,
>    ie Saturday 27th Jan.  Which I hope will be enough time for everyone
>    to get their final fixes in.
Hi,

I just stumbled over this with 2.29.1 while building a cross-toolchain,
on Cygwin64, but it's still the same for 2.30. m.arena has size_t on
Cygwin64 and thus errors out due to -Werror=format.

This little patch (similar to code further below) fixes it.


2018-01-24  Franz Sirl  <[hidden email]>

        * main.cc: Print m.arena as long long.


binutils-gold-maincc.diff (750 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Nick Clifton
In reply to this post by Joseph Myers
Hi Joseph,

> I'm now seeing a build failure from my glibc bots using 2.30 branch:
>
> In file included from /scratch/jmyers/glibc-bot/src/binutils/gprof/gprof.h:41:0,

Sorry about that. I forgot to regenerate the configure file in the
gprof sub-directory.  This should now be resolved.

Cheers
  Nick

gprof/ChangeLog
2018-01-24  Nick Clifton  <[hidden email]>

        * configure: Regenerate.
Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Nick Clifton
In reply to this post by Franz Sirl
Hi Franz,

> I just stumbled over this with 2.29.1 while building a cross-toolchain, on Cygwin64, but it's still the same for 2.30. m.arena has size_t on Cygwin64 and thus errors out due to -Werror=format.
>
> This little patch (similar to code further below) fixes it.
>
> 2018-01-24  Franz Sirl  <[hidden email]>
>
>     * main.cc: Print m.arena as long long.

This looks OK to me.  I will leave it to the Gold maintainers to decide
on its fate on the mainline, but i have taken the liberty of applying it
to the 2.30 branch sources.

Cheers
  Nick



Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

Franz Sirl
Am 2018-01-24 um 14:41 schrieb Nick Clifton:

> Hi Franz,
>
>> I just stumbled over this with 2.29.1 while building a cross-toolchain, on Cygwin64, but it's still the same for 2.30. m.arena has size_t on Cygwin64 and thus errors out due to -Werror=format.
>>
>> This little patch (similar to code further below) fixes it.
>>
>> 2018-01-24  Franz Sirl  <[hidden email]>
>>
>>      * main.cc: Print m.arena as long long.
>
> This looks OK to me.  I will leave it to the Gold maintainers to decide
> on its fate on the mainline, but i have taken the liberty of applying it
> to the 2.30 branch sources.

Hi Nick,

it seems this change didn't make it into mainline, so the problem is
back in the 2.31 branch.

Franz

Reply | Threaded
Open this post in threaded view
|

Re: 2.30 branch created, snapshot available

ccoutant
>>> I just stumbled over this with 2.29.1 while building a cross-toolchain,
>>> on Cygwin64, but it's still the same for 2.30. m.arena has size_t on
>>> Cygwin64 and thus errors out due to -Werror=format.
>>>
>>> This little patch (similar to code further below) fixes it.
>>>
>>> 2018-01-24  Franz Sirl  <[hidden email]>
>>>
>>>      * main.cc: Print m.arena as long long.
>>
>> This looks OK to me.  I will leave it to the Gold maintainers to decide
>> on its fate on the mainline, but i have taken the liberty of applying it
>> to the 2.30 branch sources.
>
> Hi Nick,
>
> it seems this change didn't make it into mainline, so the problem is back in
> the 2.31 branch.

Sorry, I missed this last time. I've cherry-picked your patch onto
2.31 and trunk.

-cary